From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [CPUFREQ] Fix implicit declarations in ondemand.
Date: Wed, 5 Jul 2006 02:36:41 -0700 [thread overview]
Message-ID: <20060705023641.21507b34.akpm@osdl.org> (raw)
In-Reply-To: <20060705092254.GA30744@redhat.com>
On Wed, 5 Jul 2006 05:22:54 -0400
Dave Jones <davej@redhat.com> wrote:
> drivers/cpufreq/cpufreq_ondemand.c: In function ‘dbs_check_cpu’:
> drivers/cpufreq/cpufreq_ondemand.c:238: error: implicit declaration of function ‘jiffies64_to_cputime64’
> drivers/cpufreq/cpufreq_ondemand.c:239: error: implicit declaration of function ‘cputime64_sub’
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/drivers/cpufreq/cpufreq_ondemand.c~ 2006-07-05 05:19:26.000000000 -0400
> +++ linux-2.6/drivers/cpufreq/cpufreq_ondemand.c 2006-07-05 05:20:01.000000000 -0400
> @@ -18,6 +18,7 @@
> #include <linux/jiffies.h>
> #include <linux/kernel_stat.h>
> #include <linux/mutex.h>
> +#include <asm/cputime.h>
>
But kernel_stat.h already includes cputime.h, as does sched.h, and pretty
much everything pulls in sched.h.
It's not bad to avoid a dependency upon nested includes, but I do wonder
how this error came about??
next prev parent reply other threads:[~2006-07-05 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 9:22 Dave Jones
2006-07-05 9:36 ` Andrew Morton [this message]
2006-07-05 9:42 ` Dave Jones
2006-07-05 9:43 ` David Woodhouse
2006-07-05 9:46 ` Dave Jones
2006-07-05 9:57 ` Andrew Morton
2006-07-05 10:24 ` David Woodhouse
2006-07-05 23:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705023641.21507b34.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®