mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Thomas Tuttle" <thinkinginbinary@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
Date: Wed, 5 Jul 2006 21:39:01 -0700	[thread overview]
Message-ID: <20060705213901.4c903e4b.akpm@osdl.org> (raw)
In-Reply-To: <e4cb19870607051948t7e6d208m729a572a65f2da5e@mail.gmail.com>

On Wed, 5 Jul 2006 22:48:17 -0400
"Thomas Tuttle" <thinkinginbinary@gmail.com> wrote:

> Here is a new version of the patch, incorporating code style tips from
> Randy Dunlap <rdunlap@xenotime.net>, and based on 2.6.17-git25, rather
> than 2.6.17.1.
> 
> I noticed that there's a Heartbeat LED trigger in the git version.  I
> hope this isn't too similar.
> 

> --- linux-2.6.17-git25/drivers/leds/Kconfig	2006-07-05 22:11:45.000000000 -0400
> +++ linux-2.6.17-git25-mine/drivers/leds/Kconfig	2006-07-05 22:42:58.000000000 -0400
> @@ -93,6 +93,41 @@
>  	  This allows LEDs to be controlled by IDE disk activity.
>  	  If unsure, say Y.
>  
> +config LEDS_TRIGGER_CPU
> +	tristate "LED CPU Trigger"
> +	depends LEDS_TRIGGERS
> +	help
> +	  This allows LEDs to be controlled by CPU activity.
> +	  If unsure, say Y.
> +
> +config LEDS_TRIGGER_CPU_INCLUDE_USER
> +	bool "Include user time in CPU trigger"
> +	depends LEDS_TRIGGER_CPU
> +	default y
> +	help
> +	  This option makes user CPU time cause the CPU trigger to activate.
> +
> +config LEDS_TRIGGER_CPU_INCLUDE_NICE
> +	bool "Include nice time in CPU trigger"
> +	depends LEDS_TRIGGER_CPU
> +	default n
> +	help
> +	  This option makes nice CPU time cause the CPU trigger to activate.
> +
> +config LEDS_TRIGGER_CPU_INCLUDE_SYSTEM
> +	bool "Include system time in CPU trigger"
> +	depends LEDS_TRIGGER_CPU
> +	default y
> +	help
> +	  This option makes system CPU time cause the CPU trigger to activate.
> +
> +config LEDS_TRIGGER_CPU_INCLUDE_IOWAIT
> +	bool "Include iowait time in CPU trigger"
> +	depends LEDS_TRIGGER_CPU
> +	default n
> +	help
> +	  This option makes iowait CPU time cause the CPU trigger to activate.

waaaaaaaaaaay too many config options.  Make up your mind, man ;)

> +cputime64_t last_cputime;

static.

> +static void __exit ledtrig_cpu_exit(void)
> +{
> +	del_timer(&ledtrig_cpu_timer);

del_timer_sync().



  parent reply	other threads:[~2006-07-06  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06  2:48 Thomas Tuttle
2006-07-06  3:01 ` Randy.Dunlap
2006-07-06  3:03   ` Thomas Tuttle
2006-07-06  3:13     ` Randy.Dunlap
2006-07-06  4:39 ` Andrew Morton [this message]
2006-07-06 13:54   ` Thomas Tuttle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060705213901.4c903e4b.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thinkinginbinary@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome