From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: "Thomas Tuttle" <thinkinginbinary@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
Date: Wed, 5 Jul 2006 20:01:26 -0700 [thread overview]
Message-ID: <20060705200126.48f83ec0.rdunlap@xenotime.net> (raw)
In-Reply-To: <e4cb19870607051948t7e6d208m729a572a65f2da5e@mail.gmail.com>
On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote:
> Here is a new version of the patch, incorporating code style tips from
> Randy Dunlap <rdunlap@xenotime.net>, and based on 2.6.17-git25, rather
> than 2.6.17.1.
>
> I noticed that there's a Heartbeat LED trigger in the git version. I
> hope this isn't too similar.
I missed at least one thing:
Don't #include <linux/config.h>
That is done automatically now by Kbuild. Source files
should not do it. (you could wait to see if there are other comments. :)
---
~Randy
next prev parent reply other threads:[~2006-07-06 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 2:48 Thomas Tuttle
2006-07-06 3:01 ` Randy.Dunlap [this message]
2006-07-06 3:03 ` Thomas Tuttle
2006-07-06 3:13 ` Randy.Dunlap
2006-07-06 4:39 ` Andrew Morton
2006-07-06 13:54 ` Thomas Tuttle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705200126.48f83ec0.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thinkinginbinary@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®