From: Chuck Ebbert <76306.1226@compuserve.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Mike Galbraith <efault@gmx.de>
Subject: [patch] i386: handle_BUG(): don't print garbage if debug info unavailable
Date: Mon, 10 Jul 2006 10:30:55 -0400 [thread overview]
Message-ID: <200607101034_MC3-1-C497-51F7@compuserve.com> (raw)
handle_BUG() tries to print file and line number even when
they're not available (CONFIG_DEBUG_BUGVERBOSE is not set.)
Change this to print a message stating info is unavailable
instead of printing a misleading message.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
---
Compile tested only, with/without CONFIG_DEBUG_BUGVERBOSE.
arch/i386/kernel/traps.c | 20 +++++++++++++-------
1 files changed, 13 insertions(+), 7 deletions(-)
--- 2.6.18-rc1-nb.orig/arch/i386/kernel/traps.c
+++ 2.6.18-rc1-nb/arch/i386/kernel/traps.c
@@ -324,13 +324,14 @@ void show_registers(struct pt_regs *regs
static void handle_BUG(struct pt_regs *regs)
{
+ unsigned long eip = regs->eip;
unsigned short ud2;
+
+#ifdef CONFIG_DEBUG_BUGVERBOSE
unsigned short line;
char *file;
char c;
- unsigned long eip;
-
- eip = regs->eip;
+#endif
if (eip < PAGE_OFFSET)
goto no_bug;
@@ -338,21 +339,26 @@ static void handle_BUG(struct pt_regs *r
goto no_bug;
if (ud2 != 0x0b0f)
goto no_bug;
+ printk(KERN_EMERG "------------[ cut here ]------------\n");
+
+#ifdef CONFIG_DEBUG_BUGVERBOSE
if (__get_user(line, (unsigned short __user *)(eip + 2)))
- goto bug;
+ goto no_info;
if (__get_user(file, (char * __user *)(eip + 4)) ||
(unsigned long)file < PAGE_OFFSET || __get_user(c, file))
file = "<bad filename>";
- printk(KERN_EMERG "------------[ cut here ]------------\n");
printk(KERN_EMERG "kernel BUG at %s:%d!\n", file, line);
+#else
+ goto no_info;
+#endif
no_bug:
return;
/* Here we know it was a BUG but file-n-line is unavailable */
-bug:
- printk(KERN_EMERG "Kernel BUG\n");
+no_info:
+ printk(KERN_EMERG "Kernel BUG at [verbose debug info unavailable]\n");
}
/* This is gone through when something in the kernel
--
Chuck
"You can't read a newspaper if you can't read." --George W. Bush
next reply other threads:[~2006-07-10 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 14:30 Chuck Ebbert [this message]
2006-07-11 8:27 ` Andrew Morton
2006-07-11 10:52 ` Nick Piggin
2006-07-11 17:02 ` Linus Torvalds
2006-07-11 17:58 ` Ray Lee
2006-07-11 23:42 ` Andrew Morton
2006-07-11 23:55 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607101034_MC3-1-C497-51F7@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome