mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ray Lee" <madrabbit@gmail.com>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: "Nick Piggin" <nickpiggin@yahoo.com.au>,
	"Andrew Morton" <akpm@osdl.org>,
	"Chuck Ebbert" <76306.1226@compuserve.com>,
	linux-kernel@vger.kernel.org, efault@gmx.de
Subject: Re: [patch] i386: handle_BUG(): don't print garbage if debug info unavailable
Date: Tue, 11 Jul 2006 10:58:00 -0700	[thread overview]
Message-ID: <2c0942db0607111058s329c8af5sf514e6d2025cf4cf@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607110959160.5623@g5.osdl.org>

On 7/11/06, Linus Torvalds <torvalds@osdl.org> wrote:
> On Tue, 11 Jul 2006, Nick Piggin wrote:
> >
> > OK but you don't need a do/while(0) here.
>
> Actually, the way Andrew wrote it, it _is_ needed. It does two things:
>
>  - it's the block scope that allows the private variables
>  - if the "get_user()" fails, the "break" means that you don't have to
>    have a goto.

<pedantry> The latter is true, but the former can also be done with
just bare braces:

  int a=4;
  {   int a=3;  printf("%d ",a); /* 3 */  }
  printf("%d ",a); /* 4 */

</pedantry, only useful to those who wish to write ugly code or source
code parsers>

Not being a person with actual *useful* skills, I can't comment on the
__get_user() issue :-).

Ray

  reply	other threads:[~2006-07-11 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 14:30 Chuck Ebbert
2006-07-11  8:27 ` Andrew Morton
2006-07-11 10:52   ` Nick Piggin
2006-07-11 17:02     ` Linus Torvalds
2006-07-11 17:58       ` Ray Lee [this message]
2006-07-11 23:42       ` Andrew Morton
2006-07-11 23:55         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db0607111058s329c8af5sf514e6d2025cf4cf@mail.gmail.com \
    --to=madrabbit@gmail.com \
    --cc=76306.1226@compuserve.com \
    --cc=akpm@osdl.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=ray-gmail@madrabbit.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®