From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Andrew Morton <akpm@osdl.org>
Cc: "Michael S. Tsirkin" <mst@mellanox.co.il>,
Ingo Molnar <mingo@elte.hu>, Zach Brown <zach.brown@oracle.com>,
openib-general@openib.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: [PATCH] IB/mthca: comment fix
Date: Mon, 10 Jul 2006 14:14:12 +0300 [thread overview]
Message-ID: <20060710111412.GD24705@mellanox.co.il> (raw)
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm and on.
---
comment in mthca_qp.c makes it seem lockdep is the only reason WQ locks should
be initialized separately, but as Zach Brown and Roland pointed out, there are
other reasons, e.g. that mthca_wq_init is called from modify qp as well.
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 490fc78..2f3917e 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -1114,7 +1114,7 @@ static int mthca_alloc_qp_common(struct
qp->sq_policy = send_policy;
mthca_wq_init(&qp->sq);
mthca_wq_init(&qp->rq);
- /* these are initialized separately so lockdep can tell them apart */
+
spin_lock_init(&qp->sq.lock);
spin_lock_init(&qp->rq.lock);
--
MST
next reply other threads:[~2006-07-10 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 11:14 Michael S. Tsirkin [this message]
2006-07-10 11:18 ` Arjan van de Ven
2006-07-10 11:31 ` Michael S. Tsirkin
2006-07-10 11:45 ` Arjan van de Ven
2006-07-10 11:59 ` Michael S. Tsirkin
2006-07-10 15:18 ` [PATCH updated] " Michael S. Tsirkin
2006-07-10 21:15 ` [PATCHv2] " Michael S. Tsirkin
2006-07-10 21:20 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710111412.GD24705@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome