* [PATCH -mm] kobject: must_check fixes
@ 2006-07-12 3:49 Randy.Dunlap
0 siblings, 0 replies; only message in thread
From: Randy.Dunlap @ 2006-07-12 3:49 UTC (permalink / raw)
To: lkml; +Cc: akpm, gregkh
From: Randy Dunlap <rdunlap@xenotime.net>
Check all __must_check warnings in lib/kobject.c
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
lib/kobject.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletion(-)
--- linux-2618-rc1mm1.orig/lib/kobject.c
+++ linux-2618-rc1mm1/lib/kobject.c
@@ -457,6 +457,7 @@ static struct kobj_type dir_ktype = {
struct kobject *kobject_add_dir(struct kobject *parent, const char *name)
{
struct kobject *k;
+ int ret;
if (!parent)
return NULL;
@@ -468,7 +469,13 @@ struct kobject *kobject_add_dir(struct k
k->parent = parent;
k->ktype = &dir_ktype;
kobject_set_name(k, name);
- kobject_register(k);
+ ret = kobject_register(k);
+ if (ret < 0) {
+ printk(KERN_WARNING "kobject_add_dir: "
+ "kobject_register error: %d\n", ret);
+ kobject_del(k);
+ return NULL;
+ }
return k;
}
---
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-07-12 3:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-12 3:49 [PATCH -mm] kobject: must_check fixes Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®