Re: [Patch 3/3] delay accounting: temporarily enable by default

Re: [Patch 3/3] delay accounting: temporarily enable by default

[Voluspa]

On 2006-07-17 21:56:03 Shailabh Nagar wrote:
> Enable delay accounting by default so that feature gets coverage testing
> without requiring special measures/

It's bloody hot in Sweden right now, and this is no Cool Aid.

> Earlier, it was off by default and had to be enabled via a boot time
> param. This patch reverses the default behaviour to improve coverage
> testing.

If it hasn't already received enough testing, what's it doing here?

> It can be removed late in the kernel development cycle if its
> believed users shouldn't have to incur any cost if they don't want
> delay accounting.

We bloody well shouldn't have.

> Or it can be retained forever if the utility of the
> stats is deemed common enough to warrant keeping the feature on.

It bloody well shouldn't be.

Corporate bloat should be hidden and buried below 45 metres of
disgusting cow dung so that innocent users don't get smelled up.

Mvh
Mats Johannesson

[Patch 0/3] delay accounting fixes

[Shailabh Nagar]

Andrew,

Following are some fixes to the delay accounting & 
taskstats patches, against 2.6.18-rc2.

The most significant change is the third patch in the
series which turns on delay accounting by default. This 
is a temporary measure to ensure that the features get
coverage testing in 2.6.18-rc kernels without requiring
kernel options to be turned on. Late in the -rc
series, it can be reversed (will send a patch to do that)

--Shailabh

[Patch 3/3] delay accounting: temporarily enable by default

[Shailabh Nagar]

Enable delay accounting by default so that feature gets coverage testing
without requiring special measures/

Earlier, it was off by default and had to be enabled via a boot time param.
This patch reverses the default behaviour to improve coverage testing. It
can be removed late in the kernel development cycle if its believed users
shouldn't have to incur any cost if they don't want delay accounting. Or it
can be retained forever if the utility of the stats is deemed common enough
to warrant keeping the feature on.

Signed-Off-By: Shailabh Nagar <nagar@watson.ibm.com>

 Documentation/accounting/delay-accounting.txt |   10 ++++++----
 Documentation/kernel-parameters.txt           |    4 ++--
 include/linux/delayacct.h                     |    4 ++--
 kernel/delayacct.c                            |    8 ++++----
 4 files changed, 14 insertions(+), 12 deletions(-)

Index: linux-2.6.18-rc2/Documentation/accounting/delay-accounting.txt
===================================================================
--- linux-2.6.18-rc2.orig/Documentation/accounting/delay-accounting.txt	2006-07-17 17:01:41.000000000 -0400
+++ linux-2.6.18-rc2/Documentation/accounting/delay-accounting.txt	2006-07-17 17:07:54.000000000 -0400
@@ -64,11 +64,13 @@ Compile the kernel with
 	CONFIG_TASK_DELAY_ACCT=y
 	CONFIG_TASKSTATS=y
 
-Enable the accounting at boot time by adding
-the following to the kernel boot options
-	delayacct
+Delay accounting is enabled by default at boot up.
+To disable, add
+   nodelayacct
+to the kernel boot options. The rest of the instructions
+below assume this has not been done.
 
-and after the system has booted up, use a utility
+After the system has booted up, use a utility
 similar to  getdelays.c to access the delays
 seen by a given task or a task group (tgid).
 The utility also allows a given command to be
Index: linux-2.6.18-rc2/kernel/delayacct.c
===================================================================
--- linux-2.6.18-rc2.orig/kernel/delayacct.c	2006-07-17 17:01:51.000000000 -0400
+++ linux-2.6.18-rc2/kernel/delayacct.c	2006-07-17 17:07:54.000000000 -0400
@@ -19,15 +19,15 @@
 #include <linux/sysctl.h>
 #include <linux/delayacct.h>
 
-int delayacct_on __read_mostly;	/* Delay accounting turned on/off */
+int delayacct_on __read_mostly = 1;	/* Delay accounting turned on/off */
 kmem_cache_t *delayacct_cache;
 
-static int __init delayacct_setup_enable(char *str)
+static int __init delayacct_setup_disable(char *str)
 {
-	delayacct_on = 1;
+	delayacct_on = 0;
 	return 1;
 }
-__setup("delayacct", delayacct_setup_enable);
+__setup("nodelayacct", delayacct_setup_disable);
 
 void delayacct_init(void)
 {
Index: linux-2.6.18-rc2/Documentation/kernel-parameters.txt
===================================================================
--- linux-2.6.18-rc2.orig/Documentation/kernel-parameters.txt	2006-07-17 17:01:41.000000000 -0400
+++ linux-2.6.18-rc2/Documentation/kernel-parameters.txt	2006-07-17 17:07:54.000000000 -0400
@@ -448,8 +448,6 @@ running once the system is up.
 			Format: <area>[,<node>]
 			See also Documentation/networking/decnet.txt.
 
-	delayacct	[KNL] Enable per-task delay accounting
-
 	dhash_entries=	[KNL]
 			Set number of hash buckets for dentry cache.
 
@@ -1031,6 +1029,8 @@ running once the system is up.
 
 	nocache		[ARM]
 
+	nodelayacct	[KNL] Disable per-task delay accounting
+
 	nodisconnect	[HW,SCSI,M68K] Disables SCSI disconnects.
 
 	noexec		[IA-64]
Index: linux-2.6.18-rc2/include/linux/delayacct.h
===================================================================
--- linux-2.6.18-rc2.orig/include/linux/delayacct.h	2006-07-17 17:03:41.000000000 -0400
+++ linux-2.6.18-rc2/include/linux/delayacct.h	2006-07-17 17:07:54.000000000 -0400
@@ -55,7 +55,7 @@ static inline void delayacct_tsk_init(st
 {
 	/* reinitialize in case parent's non-null pointer was dup'ed*/
 	tsk->delays = NULL;
-	if (unlikely(delayacct_on))
+	if (delayacct_on)
 		__delayacct_tsk_init(tsk);
 }
 
@@ -80,7 +80,7 @@ static inline void delayacct_blkio_end(v
 static inline int delayacct_add_tsk(struct taskstats *d,
 					struct task_struct *tsk)
 {
-	if (likely(!delayacct_on) || !tsk->delays)
+	if (!delayacct_on || !tsk->delays)
 		return 0;
 	return __delayacct_add_tsk(d, tsk);
 }