From: Komal Shah <komal_shah802003@yahoo.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: akpm@osdl.org, juha.yrjola@solidboot.com, tony@atomide.com,
ext-timo.teras@nokia.com, r-woodruff2@ti.com,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: Add keypad driver #2
Date: Tue, 25 Jul 2006 22:17:21 -0700 (PDT) [thread overview]
Message-ID: <20060726051721.18126.qmail@web37913.mail.mud.yahoo.com> (raw)
In-Reply-To: <d120d5000607251332ma001b27teaf0f07d6c122362@mail.gmail.com>
--- Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> Hi Komal,
>
> The driver needs to handle failures in input_register_device() and
> unwind initialization properly. Also you do not need to do double
> negation of the value when calling input_report_key() because it will
> do it for you.
>
> Also you might consider setting up keycodetable, keycodesize, etc in
> the input device - this way you can change keymap at runtime via
> ioctls.
Thanx for the review. I will update the driver and submit to list soon.
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
prev parent reply other threads:[~2006-07-26 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 10:57 Komal Shah
2006-07-25 20:32 ` Dmitry Torokhov
2006-07-26 5:17 ` Komal Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726051721.18126.qmail@web37913.mail.mud.yahoo.com \
--to=komal_shah802003@yahoo.com \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ext-timo.teras@nokia.com \
--cc=juha.yrjola@solidboot.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=r-woodruff2@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®