From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Komal Shah" <komal_shah802003@yahoo.com>
Cc: akpm@osdl.org, juha.yrjola@solidboot.com, tony@atomide.com,
ext-timo.teras@nokia.com, r-woddruff2@ti.com,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: Add keypad driver #2
Date: Tue, 25 Jul 2006 16:32:44 -0400 [thread overview]
Message-ID: <d120d5000607251332ma001b27teaf0f07d6c122362@mail.gmail.com> (raw)
In-Reply-To: <1153825050.6486.266809347@webmail.messagingengine.com>
On 7/25/06, Komal Shah <komal_shah802003@yahoo.com> wrote:
> Andrew/Tony/Richard,
>
> This is a revised patch as per the review comments from the Andrew
> on thread:
>
> http://lkml.org/lkml/2006/7/22/19
>
> Please review it and give me the Ack if looks ok.
>
Hi Komal,
The driver needs to handle failures in input_register_device() and
unwind initialization properly. Also you do not need to do double
negation of the value when calling input_report_key() because it will
do it for you.
Also you might consider setting up keycodetable, keycodesize, etc in
the input device - this way you can change keymap at runtime via
ioctls.
--
Dmitry
next prev parent reply other threads:[~2006-07-25 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 10:57 Komal Shah
2006-07-25 20:32 ` Dmitry Torokhov [this message]
2006-07-26 5:17 ` Komal Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000607251332ma001b27teaf0f07d6c122362@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=ext-timo.teras@nokia.com \
--cc=juha.yrjola@solidboot.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=r-woddruff2@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®