Re: [PATCH] knfsd: Fix stale file handle problem with subtree_checking.

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Jul 28, 2006 at 07:42:55PM +1000, NeilBrown wrote:
> The following patch fixes a bug that was introduced since 2.6.17,
> and should go in 2.6.18.
> 
> ### Comments for Changeset
> 
> A recent patch:
> 
>   h=7fc90ec93a5eb71f4b08403baf5ba7176b3ec6b1
> 
> moved the call to nfsd_setuser out of the 'find a dentry for a
> filehandle' branch of fh_verify so that it would always be called.
> 
> This had the unfortunately side-effect of moving *after* the call
> to decode_fh, so the prober fsuid was not set when nfsd_acceptable
> was called, the 'permission' check did the wrong thing.

Argh, sorry, thanks for the fix.

It'd be great if we could deprecate subtree checking some day in the
distant future....

Would it be feasible to add filesystem support for some sort of
subvolume-like thing that acted like a mountpoint (in the sense that it
restricted hardlinks and renames) but that didn't require setting aside
a separate partition?  I imagine that'd probably do what most people
exporting subtrees want without forcing us to do dubious tricks with
filehandles.

--b.