mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] knfsd: Fix stale file handle problem with subtree_checking.
Date: Mon, 31 Jul 2006 12:16:33 -0400	[thread overview]
Message-ID: <20060731161633.GB11459@fieldses.org> (raw)
In-Reply-To: <17610.62013.790217.817455@cse.unsw.edu.au>

On Sat, Jul 29, 2006 at 03:29:33PM +1000, Neil Brown wrote:
> The first step would be to stop it from being the default (as Trond
> has suggested a number of times :-)
> 
> How about this.
>  I release a 1.0.10 shortly which addresses some 'portlist' related
>  breakage and prints a nasty warning if you have neither subtree_check
>  or no_subtree_check, but still defaults to subtree_check.
> 
>  Then the next release will be 1.1.0 which prints the same warning,
>  but defaults the other way - and probably removed the warning if you
>  include neither sync not async.
> 
> That should at least get subtree_check to be used less.

Sounds good to me.  (Though for these kinds of changes I suppose it's
the time elasped that matters more than the number of released
versions--people probably upgrade every x months/years/whatever rather
than every x versions.  By that criteria I think we might be making the
subtree_check change a little fast, while the warning period for the
sync change may already be overkill....)

> I think it is a great idea for a 'filesystem' to support multiple
> independent file-trees within the one storage set, which is roughly
> what you are saying I think (though probably not quite).
> 
> However I suspect that most people don't actually want subtrees.  They
> just get it as the default.  It isn't something that I would have
> implemented if I hadn't inherited the requirement, and no other OS
> that I know of provides that particular semantic.

Could be.

--b.

      reply	other threads:[~2006-07-31 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060728194103.7245.patches@notabene>
2006-07-28  9:42 ` NeilBrown
2006-07-28 20:51   ` J. Bruce Fields
2006-07-29  5:29     ` Neil Brown
2006-07-31 16:16       ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060731161633.GB11459@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®