2.6.18-rc2-git7 build error with CONFIG_STACK_UNWIND enabled

2.6.18-rc2-git7 build error with CONFIG_STACK_UNWIND enabled

[Jesper Juhl]

For Your Information :

With 2.6.18-rc2-git7 I get the following build error if I have
CONFIG_STACK_UNWIND enabled :

  CC      arch/i386/kernel/traps.o
arch/i386/kernel/traps.c: In function `show_trace_log_lvl':
arch/i386/kernel/traps.c:193: error: invalid type argument of `->'
arch/i386/kernel/traps.c:196: error: invalid type argument of `->'
arch/i386/kernel/traps.c:197: error: invalid type argument of `->'
make[1]: *** [arch/i386/kernel/traps.o] Error 1
make: *** [arch/i386/kernel] Error 2


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: 2.6.18-rc2-git7 build error with CONFIG_STACK_UNWIND enabled

[Alexey Dobriyan]

On Sat, Jul 29, 2006 at 03:41:46PM +0200, Jesper Juhl wrote:
> With 2.6.18-rc2-git7 I get the following build error if I have
> CONFIG_STACK_UNWIND enabled :
> 
>  CC      arch/i386/kernel/traps.o
> arch/i386/kernel/traps.c: In function `show_trace_log_lvl':
> arch/i386/kernel/traps.c:193: error: invalid type argument of `->'
> arch/i386/kernel/traps.c:196: error: invalid type argument of `->'
> arch/i386/kernel/traps.c:197: error: invalid type argument of `->'

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

--- a/arch/i386/kernel/traps.c
+++ b/arch/i386/kernel/traps.c
@@ -190,11 +190,11 @@ static void show_trace_log_lvl(struct ta
 		if (unw_ret > 0 && !arch_unw_user_mode(&info)) {
 #ifdef CONFIG_STACK_UNWIND
 			print_symbol("DWARF2 unwinder stuck at %s\n",
-				     UNW_PC(info.regs));
+				     UNW_PC(&info));
 			if (call_trace == 1) {
 				printk("Leftover inexact backtrace:\n");
-				if (UNW_SP(info.regs))
-					stack = (void *)UNW_SP(info.regs);
+				if (UNW_SP(&info))
+					stack = (void *)UNW_SP(&info);
 			} else if (call_trace > 1)
 				return;
 			else

Re: 2.6.18-rc2-git7 build error with CONFIG_STACK_UNWIND enabled

[Jesper Juhl]

On Saturday 29 July 2006 16:26, Alexey Dobriyan wrote:
> On Sat, Jul 29, 2006 at 03:41:46PM +0200, Jesper Juhl wrote:
> > With 2.6.18-rc2-git7 I get the following build error if I have
> > CONFIG_STACK_UNWIND enabled :
> > 
> >  CC      arch/i386/kernel/traps.o
> > arch/i386/kernel/traps.c: In function `show_trace_log_lvl':
> > arch/i386/kernel/traps.c:193: error: invalid type argument of `->'
> > arch/i386/kernel/traps.c:196: error: invalid type argument of `->'
> > arch/i386/kernel/traps.c:197: error: invalid type argument of `->'
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> 
> --- a/arch/i386/kernel/traps.c
> +++ b/arch/i386/kernel/traps.c
> @@ -190,11 +190,11 @@ static void show_trace_log_lvl(struct ta
>  		if (unw_ret > 0 && !arch_unw_user_mode(&info)) {
>  #ifdef CONFIG_STACK_UNWIND
>  			print_symbol("DWARF2 unwinder stuck at %s\n",
> -				     UNW_PC(info.regs));
> +				     UNW_PC(&info));
>  			if (call_trace == 1) {
>  				printk("Leftover inexact backtrace:\n");
> -				if (UNW_SP(info.regs))
> -					stack = (void *)UNW_SP(info.regs);
> +				if (UNW_SP(&info))
> +					stack = (void *)UNW_SP(&info);
>  			} else if (call_trace > 1)
>  				return;
>  			else
> 
> 
I can confirm that this fixes the build error.
Thanks Alexey.

/ Jesper Juhl <jesper.juhl@gmail.com> /