From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [BLOCK] bh: Ensure bh fits within a page
Date: Mon, 31 Jul 2006 22:54:54 -0700 [thread overview]
Message-ID: <20060731225454.19981a5f.akpm@osdl.org> (raw)
In-Reply-To: <20060801050259.GA3126@gondor.apana.org.au>
On Tue, 1 Aug 2006 15:02:59 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Mon, Jul 31, 2006 at 09:04:18PM -0700, Andrew Morton wrote:
> >
> > Could we have a more detailed description?
>
> Sure, this particular instance is in journal_write_metadata_buffer
> where the bh may be constructed from kmalloc memory (search for the
> call to jbd_rep_kmalloc). Because the memory returned by kmalloc
> may straddle a page (when slab debugging is enabled that is), this
> causes a broken bh to be injected into submit_bh.
>
Crap, that's hard to fix. Am I allowed to blame submit_bh()? ;)
uhm, we don't want to lose kmalloc redzoning, so I guess we need to create
on-demand ext3-private slab caches for 1024, 2048, and 4096 bytes. With
the appropriate slab flags to defeat the redzoning.
next prev parent reply other threads:[~2006-08-01 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 3:04 Herbert Xu
2006-08-01 4:04 ` Andrew Morton
2006-08-01 5:02 ` Herbert Xu
2006-08-01 5:54 ` Andrew Morton [this message]
2006-08-01 11:06 ` Herbert Xu
2006-08-01 14:45 ` Andrew Morton
2006-08-01 17:36 ` Christoph Lameter
2006-08-01 19:08 ` Pekka Enberg
2006-08-01 19:08 ` Steven Rostedt
2006-08-01 19:10 ` Christoph Lameter
2006-08-01 19:35 ` Steven Rostedt
2006-08-01 19:55 ` Christoph Lameter
2006-08-01 7:23 ` Jens Axboe
2006-08-01 23:30 ` Herbert Xu
2006-08-01 23:32 ` Herbert Xu
2006-08-02 6:23 ` Jens Axboe
2006-08-01 23:44 ` Andrew Morton
2006-08-17 23:14 ` Badari Pulavarty
2006-08-18 2:53 ` Herbert Xu
2006-08-01 19:33 ` Andi Kleen
2006-08-01 22:09 ` Herbert Xu
2006-08-02 11:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731225454.19981a5f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®