From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: axboe@suse.de (Jens Axboe), linux-kernel@vger.kernel.org
Subject: Re: [BLOCK] bh: Ensure bh fits within a page
Date: Tue, 1 Aug 2006 16:44:08 -0700 [thread overview]
Message-ID: <20060801164408.bd0305f3.akpm@osdl.org> (raw)
In-Reply-To: <E1G83hL-00035h-00@gondolin.me.apana.org.au>
On Wed, 02 Aug 2006 09:30:51 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Jens Axboe <axboe@suse.de> wrote:
> >
> > That looks really dangerous, I'd prefer that to be a BUG_ON() as well to
> > prevent nastiness further down.
>
> OK, I used a WARN_ON mainly because ext3 has been doing this for years
> without killing anyone until now :)
I can't apply either of these patches, because we _know_ it'll trigger.
Once the JBD fix is in hand, we can go with a WARN_ON_ONCE and if that is
all clear, then we can make it a BUG_ON().
next prev parent reply other threads:[~2006-08-01 23:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 3:04 Herbert Xu
2006-08-01 4:04 ` Andrew Morton
2006-08-01 5:02 ` Herbert Xu
2006-08-01 5:54 ` Andrew Morton
2006-08-01 11:06 ` Herbert Xu
2006-08-01 14:45 ` Andrew Morton
2006-08-01 17:36 ` Christoph Lameter
2006-08-01 19:08 ` Pekka Enberg
2006-08-01 19:08 ` Steven Rostedt
2006-08-01 19:10 ` Christoph Lameter
2006-08-01 19:35 ` Steven Rostedt
2006-08-01 19:55 ` Christoph Lameter
2006-08-01 7:23 ` Jens Axboe
2006-08-01 23:30 ` Herbert Xu
2006-08-01 23:32 ` Herbert Xu
2006-08-02 6:23 ` Jens Axboe
2006-08-01 23:44 ` Andrew Morton [this message]
2006-08-17 23:14 ` Badari Pulavarty
2006-08-18 2:53 ` Herbert Xu
2006-08-01 19:33 ` Andi Kleen
2006-08-01 22:09 ` Herbert Xu
2006-08-02 11:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801164408.bd0305f3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome