[PATCH 2.6.18-rc3, 2.6.17.7] ieee1394: sbp2: enable auto spin-up for Maxtor disks

[PATCH 2.6.18-rc3, 2.6.17.7] ieee1394: sbp2: enable auto spin-up for Maxtor disks

[Stefan Richter]

At least Maxtor OneTouch III require a "start stop unit" command after
auto spin-down before the next access can proceed.  This patch activates
the responsible code in scsi_mod for all Maxtor SBP-2 disks.
https://bugzilla.novell.com/show_bug.cgi?id=183011

Maybe that should be done for all SBP-2 disks, but better be cautious.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
This patch is also available from the ieee1394 git tree:
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/linux1394-2.6.git;a=commitdiff;h=31a379e1067834868b8f1ce3e409392c42dc0f2b

Fixes loss of connection if an external Maxtor disk automatically went
into power saving mode.

Enthusiasts may pick up a variant of this patch for 2.6.16.y at
https://bugzilla.novell.com/show_bug.cgi?id=183011#c6

Index: linux/drivers/ieee1394/sbp2.c
===================================================================
--- linux.orig/drivers/ieee1394/sbp2.c	2006-07-01 09:37:55.000000000 +0200
+++ linux/drivers/ieee1394/sbp2.c	2006-07-01 09:41:33.000000000 +0200
@@ -2515,6 +2515,9 @@ static int sbp2scsi_slave_configure(stru
 		sdev->skip_ms_page_8 = 1;
 	if (scsi_id->workarounds & SBP2_WORKAROUND_FIX_CAPACITY)
 		sdev->fix_capacity = 1;
+	if (scsi_id->ne->guid_vendor_id == 0x0010b9 && /* Maxtor's OUI */
+	    (sdev->type == TYPE_DISK || sdev->type == TYPE_RBC))
+		sdev->allow_restart = 1;
 	return 0;
 }
 

Re: [stable] [PATCH 2.6.18-rc3, 2.6.17.7] ieee1394: sbp2: enable auto spin-up for Maxtor disks

[Greg KH]

On Wed, Aug 02, 2006 at 07:40:06PM +0200, Stefan Richter wrote:
> At least Maxtor OneTouch III require a "start stop unit" command after
> auto spin-down before the next access can proceed.  This patch activates
> the responsible code in scsi_mod for all Maxtor SBP-2 disks.
> https://bugzilla.novell.com/show_bug.cgi?id=183011
> 
> Maybe that should be done for all SBP-2 disks, but better be cautious.
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Queued to -stable.

thanks,

greg k-h