From: Andrew Morton <akpm@osdl.org>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386: mark two more functions as __init
Date: Tue, 8 Aug 2006 12:58:03 -0700 [thread overview]
Message-ID: <20060808125803.9aac260f.akpm@osdl.org> (raw)
In-Reply-To: <20060808081756.334.46571.sendpatchset@cherry.local>
On Tue, 8 Aug 2006 17:17:00 +0900 (JST)
Magnus Damm <magnus@valinux.co.jp> wrote:
> i386: mark two more functions as __init
>
> cyrix_identify() should be __init because transmeta_identify() is.
> tsc_init() is only called from setup_arch() which is marked as __init.
>
> These two section mismatches have been detected using running modpost on
> a vmlinux image compiled with CONFIG_RELOCATABLE=y.
>
> -static void cyrix_identify(struct cpuinfo_x86 * c)
> +static void __init cyrix_identify(struct cpuinfo_x86 * c)
Are we sure? We end up putting a pointer to this into
arch/i386/kernel/cpu/common.c:cpu_devs[], and that gets used from __cpuinit
code.
next prev parent reply other threads:[~2006-08-08 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 8:17 Magnus Damm
2006-08-08 9:15 ` Andi Kleen
2006-08-08 19:58 ` Andrew Morton [this message]
2006-08-09 0:14 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808125803.9aac260f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome