Re: SCSI trow USB-STORAGE or SBP2 Debug for buggy device Kernels 2.6.X

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* Re: SCSI trow USB-STORAGE or SBP2 Debug for buggy device Kernels 2.6.X
       [not found]   ` <1146001711.3529.58.camel@mulgrave.il.steeleye.com>
@ 2006-04-28  1:38     ` Gustavo Guillermo Pérez
  0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Guillermo Pérez @ 2006-04-28  1:38 UTC (permalink / raw)
  To: linux-kernel

El Martes, 25 de Abril de 2006 16:48, James Bottomley escribió:
> OK ... My best guess has to be that this device accepted and completed
> the command but is still processing it on the medium, hence the return.
> Try the attached; I think it makes for these cases.  I could be
> persuaded to drop format and reconstruction in progress, because those
> can be *very* long operations.
Let me see, the patch of course does not apply, but I can figure out how to 
proceed on kernel 2.6.16.

But guess who, not Device busy as error, of course and NO BAD SECTORS With 
pktcdvd UDF.

:)

Txs, do you think this modification I can use without care on Sata o other 
devices going trow SCSI?, cause I be wonder if this could be into main kernel 
line.

Regards!!!!

> James
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 7b0f9a3..764a8b3 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1067,16 +1067,29 @@ void scsi_io_completion(struct scsi_cmnd
>  			break;
>  		case NOT_READY:
>  			/*
> -			 * If the device is in the process of becoming ready,
> -			 * retry.
> +			 * If the device is in the process of becoming
> +			 * ready, or has a temporary blockage, retry.
>  			 */
> -			if (sshdr.asc == 0x04 && sshdr.ascq == 0x01) {
> -				scsi_requeue_command(q, cmd);
> -				return;
> +			if (sshdr.asc == 0x04) {
> +				switch (sshdr.ascq) {
> +				case 0x01: /* becoming ready */
> +				case 0x04: /* format in progress */
> +				case 0x05: /* rebuild in progress */
> +				case 0x06: /* recalculation in progress */
> +				case 0x07: /* operation in progress */
> +				case 0x08: /* Long write in progress */
> +				case 0x09: /* self test in progress */
> +					scsi_requeue_command(q, cmd);
> +					return;
> +				default:
> +					break;
> +				}
>  			}
> -			if (!(req->flags & REQ_QUIET))
> +			if (!(req->flags & REQ_QUIET)) {
>  				scmd_printk(KERN_INFO, cmd,
> -					   "Device not ready.\n");
> +					   "Device not ready: ");
> +				scsi_print_sense_hdr("", &sshdr);
> +			}
>  			scsi_end_request(cmd, 0, this_count, 1);
>  			return;
>  		case VOLUME_OVERFLOW:

-- 
Gustavo Guillermo Pérez
Compunauta uLinux
www.compunauta.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

[parent not found: <20060730160808.d67f71bb.akpm@osdl.org>]

* Re: SCSI trow USB-STORAGE or SBP2 Debug for buggy device Kernels 2.6.X
       [not found] ` <20060730160808.d67f71bb.akpm@osdl.org>
@ 2006-08-09  4:03   ` Gustavo Guillermo Pérez
  0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Guillermo Pérez @ 2006-08-09  4:03 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel

El Domingo, 30 de Julio de 2006 18:08, escribió:
> If this is still happening in 2.6.18-rc3 could you please raise a report at
> bugzilla.kernel.org?
It does not happen, Thanks.
Sorry for the late testing.
> Thanks.
>
>
> On Mon, 24 Apr 2006 10:29:14 -0500
>
> Gustavo Guillermo Pérez <gustavo@compunauta.com> wrote:
> > Hello, list, I've tried to figure out why my external DVDRW Device has a
> > problem using UDF, SCSI subsystem reports "Device not ready" when burning
> > with growisofs, the media is being written perfect, no defective media or
> > sector errors ater burning. I've tried diferent DVDRW and I discover that
> > only pioneer has this issue DVR106D /107D/108D/109D/110D (I have a lot of
> > them) but only trow usb-storage or sbp2 device converters I have this
> > error, and with this error UDF system show bad sectors, there is not bad
> > sectors, and it happens only when writing big files about more than 1 or
> > 2MB, not 100Kbyte files or many small files, Then is cause I guess the
> > drive need some time to get ready again and I guess scsi system can
> > resend the
> > command?!?!?!?.
> >
> > Then going more far away, I see there is a black list on SCSI system,
> > scsi_devinfo.c that has a list of vendor and product identifications.
> > I've tried to add this line:
> > {"PIONEER", "DVD-RW  DVR-106D", NULL, BLIST_RETRY_HWERROR},
> >
> > With no effects, Cause this error looks like not hardware error, is just
> > not ready.
> >
> > Then I have an Idea, what happen if on scsi_lib.c where resides the
> > faulty code:
> > if (!(req->flags & REQ_QUIET))
> >               dev_printk(KERN_INFO,
> >               &cmd->device->sdev_gendev,
> >               "Device not ready.\n");
> >               scsi_end_request(cmd, 0, this_count, 1);
> >               return;
> > I change scsi_end_request(cmd, 0, this_count, 1);
> > by a comparison about vendor ID and Model
> > and then if is a buggy one executes scsi_requeue_command(q, cmd); instead
> > of scsi_end_request(cmd, 0, this_count, 1);
> >
> > Can I use this vars to deal only the same situation and not sata, nor
> > usb-card reader, etc. etc.?!?!?!??!?!?!?!?
> > &cmd->device->vendor
> > &cmd->device->model
> > &cmd->pid
> > &cmd->sc_magic
> >
> > How can I print it with prontk, I should use ?!?!?!
> > printk("Vendor: %s Model: %s Pid: %s Magic %s DevNotReady_Error\n",
> >         &cmd->device->vendor,
> >         &cmd->device->model,
> >         &cmd->pid,
> >         &cmd->sc_magic);
> >
> > This device seems to require more patient to get ready...
> >
> > this is my log USB-STORAGE generic adapter
> >
> > Apr  3 18:13:30 g kernel: usb 4-1: new full speed USB device using
> > ehci_hcd and address 2
> > Apr  3 18:13:30 g kernel: scsi2 : SCSI emulation for USB Mass Storage
> > devices Apr  3 18:13:35 g kernel:   Vendor: PIONEER   Model: DVD-RW 
> > DVR-106D  Rev: 1.08
> > Apr  3 18:13:35 g kernel:   Type:   CD-ROM                            
> > ANSI SCSI revision: 00
> > Apr  3 18:13:35 g kernel: sr0: scsi3-mmc drive: 32x/32x writer cd/rw
> > xa/form2 cdda tray
> > Apr  3 18:13:35 g scsi.agent[14695]: cdrom
> > at
> > /devices/pci0000:00/0000:00:10.3/usb4/4-1/4-1:1.0/host2/target2:0:0/2:0:0
> >:0 Apr  3 18:13:53 g kernel: cdrom: This disc doesn't have any tracks I
> > recognize!
> > Apr  3 18:14:42 g kernel: sr 2:0:0:0: Device not ready.
> > Apr  3 18:15:13 g last message repeated 21 times
> > Apr  3 18:16:14 g last message repeated 31 times
> > Apr  3 18:17:16 g last message repeated 31 times
> > Apr  3 18:18:17 g last message repeated 31 times
> > Apr  3 18:19:19 g last message repeated 31 times
> > Apr  3 18:20:20 g last message repeated 30 times
> > Apr  3 18:21:21 g last message repeated 28 times
> > Apr  3 18:22:22 g last message repeated 30 times
> > Apr  3 18:23:24 g last message repeated 31 times
> >
> > diferent USB-STORAGE+ieee1394:
> > Apr  7 23:28:54 g kernel: sbp2: $Rev: 1306 $ Ben Collins
> > <bcollins@debian.org> Apr  7 23:28:54 g kernel: scsi2 : SCSI emulation
> > for IEEE-1394 SBP-2 Devices Apr  7 23:28:55 g kernel: ieee1394: sbp2:
> > Logged into SBP-2 device Apr  7 23:28:55 g kernel:   Vendor: PIONEER  
> > Model: DVD-RW  DVR-110D  Rev: 1.37
> > Apr  7 23:28:55 g kernel:   Type:   CD-ROM                            
> > ANSI SCSI revision: 00
> > Apr  7 23:28:55 g kernel: sr1: scsi3-mmc drive: 1x/351x xa/form2 tray
> > Apr  7 23:28:55 g scsi.agent[9237]: cdrom
> > at
> > /devices/pci0000:00/0000:00:14.0/fw-host0/0050c50250004101/0050c502500041
> >01-0/h Apr  7 23:28:56 g fstab-sync[9271]: added mount point /media/cdrom
> > for /dev/sr1
> > Apr  7 23:28:56 g kernel: cdrom: This disc doesn't have any tracks I
> > recognize!
> > Apr  7 23:32:11 g kernel: sr 2:0:0:0: Device not ready.
> > Apr  7 23:32:42 g last message repeated 290 times
> > Apr  7 23:33:45 g last message repeated 182 times
> > Apr  7 23:34:46 g last message repeated 92 times
> > Apr  7 23:35:47 g last message repeated 87 times
> > Apr  7 23:36:48 g last message repeated 103 times
> > Apr  7 23:37:50 g last message repeated 128 times
> > Apr  7 23:38:51 g last message repeated 140 times
> > Apr  7 23:39:52 g last message repeated 157 times
> > Apr  7 23:40:06 g last message repeated 65 times
> >
> > SBP2 with another DVDR107
> > Oct 11 10:53:52 g kernel: sbp2: $Rev: 1219 $ Ben Collins
> > <bcollins@debian.org> Oct 11 10:53:52 g kernel: scsi0 : SCSI emulation
> > for IEEE-1394 SBP-2 Devices Oct 11 10:53:52 g net.agent[8231]: add event
> > not handled
> > Oct 11 10:53:53 g kernel: ieee1394: sbp2: Logged into SBP-2 device
> > Oct 11 10:53:53 g kernel:   Vendor: PIONEER   Model: DVD-RW  DVR-107D 
> > Rev: 1.21
> > Oct 11 10:53:53 g kernel:   Type:   CD-ROM                            
> > ANSI SCSI revision: 02
> > Oct 11 10:53:53 g kernel: sr0: scsi3-mmc drive: 62x/62x writer cd/rw
> > xa/form2 cdda tray
> > Oct 11 10:53:53 g scsi.agent[8285]: cdrom
> > at
> > /devices/pci0000:00/0000:00:14.0/fw-host0/0050c50250004101/0050c502500041
> >01-0/h Oct 11 10:56:21 g kernel: XFS mounting filesystem hda6
> > Oct 11 11:00:09 g kernel: Device sr0 not ready.
> > Oct 11 11:00:40 g last message repeated 145 times
> > Oct 11 11:01:41 g last message repeated 178 times
> > Oct 11 11:02:40 g last message repeated 174 times
> >
> >
> > any thougts?
> >
> > --
> > Gustavo Guillermo Pérez
> > Compunauta uLinux
> > www.compunauta.com

-- 
Gustavo Guillermo Pérez
Compunauta uLinux
www.compunauta.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-09 17:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200604241029.14932.gustavo@compunauta.com>
     [not found] ` <200604251641.54084.gustavo@compunauta.com>
     [not found]   ` <1146001711.3529.58.camel@mulgrave.il.steeleye.com>
2006-04-28  1:38     ` SCSI trow USB-STORAGE or SBP2 Debug for buggy device Kernels 2.6.X Gustavo Guillermo Pérez
     [not found] ` <20060730160808.d67f71bb.akpm@osdl.org>
2006-08-09  4:03   ` Gustavo Guillermo Pérez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome