From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: Magnus Damm <magnus@valinux.co.jp>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for review] [140/145] i386: mark cpu_dev structures as __cpuinitdata
Date: Fri, 11 Aug 2006 11:24:03 -0400 [thread overview]
Message-ID: <200608111126_MC3-1-C7CA-65CE@compuserve.com> (raw)
In-Reply-To: <20060810193740.9133413C0B@wotan.suse.de>
On Thu, 10 Aug 2006 21:37:40 +0200, Andi Kleen wrote:
> From: Magnus Damm <magnus@valinux.co.jp>
>
> The different cpu_dev structures are all used from __cpuinit callers what
> I can tell. So mark them as __cpuinitdata instead of __initdata. I am a
> little bit unsure about arch/i386/common.c:default_cpu, especially when it
> comes to the purpose of this_cpu.
But none of these CPUs supports hotplug and only one (AMD) does SMP.
So this is just wasting space in the kernel at runtime.
If anything I would only do this for AMD.
Same for the other patch that does more of this kind of change.
(IIRC I tried to do this a while ago and was told not to.)
--
Chuck
next reply other threads:[~2006-08-11 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 15:24 Chuck Ebbert [this message]
2006-08-11 16:07 ` Andi Kleen
2006-08-14 1:26 ` Magnus Damm
-- strict thread matches above, loose matches on Subject: below --
2006-08-15 6:46 Chuck Ebbert
2006-08-15 7:43 ` Arjan van de Ven
2006-08-15 16:59 ` Dave Jones
[not found] <20060810 935.775038000@suse.de>
2006-08-10 19:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608111126_MC3-1-C7CA-65CE@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome