From: Andrew Morton <akpm@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, cmm@us.ibm.com
Subject: Re: + ext3-and-jbd-cleanup-replace-brelse-to-put_bh.patch added to -mm tree
Date: Mon, 14 Aug 2006 16:16:34 -0700 [thread overview]
Message-ID: <20060814161634.a24fe5a2.akpm@osdl.org> (raw)
In-Reply-To: <20060814225941.GB5175@martell.zuzino.mipt.ru>
On Tue, 15 Aug 2006 02:59:41 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Fri, Aug 11, 2006 at 06:46:13PM -0700, akpm@osdl.org wrote:
> > Replace all brelse() calls with put_bh(). Because brelse() is
> > old-fashioned, has a weird name and neelessly permits a NULL
>
> > --- a/fs/ext3/balloc.c~ext3-and-jbd-cleanup-replace-brelse-to-put_bh
> > +++ a/fs/ext3/balloc.c
> > @@ -351,7 +351,7 @@ do_more:
> > overflow = bit + count - EXT3_BLOCKS_PER_GROUP(sb);
> > count -= overflow;
> > }
> > - brelse(bitmap_bh);
> > + put_bh(bitmap_bh);
>
> Is it safe to always s/brelse/put_bh/ ? Or someone has to audit every
> occurence for this "neelessly permits a NULL"?
Yeah, it crashed all over the place.
I'd be inclined to give up on this idea. Life's too short.
prev parent reply other threads:[~2006-08-14 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608120146.k7C1kDVd006044@shell0.pdx.osdl.net>
2006-08-14 22:59 ` Alexey Dobriyan
2006-08-14 23:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814161634.a24fe5a2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adobriyan@gmail.com \
--cc=cmm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®