* Re: + ext3-and-jbd-cleanup-replace-brelse-to-put_bh.patch added to -mm tree
[not found] <200608120146.k7C1kDVd006044@shell0.pdx.osdl.net>
@ 2006-08-14 22:59 ` Alexey Dobriyan
2006-08-14 23:16 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-08-14 22:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, cmm
On Fri, Aug 11, 2006 at 06:46:13PM -0700, akpm@osdl.org wrote:
> Replace all brelse() calls with put_bh(). Because brelse() is
> old-fashioned, has a weird name and neelessly permits a NULL
> --- a/fs/ext3/balloc.c~ext3-and-jbd-cleanup-replace-brelse-to-put_bh
> +++ a/fs/ext3/balloc.c
> @@ -351,7 +351,7 @@ do_more:
> overflow = bit + count - EXT3_BLOCKS_PER_GROUP(sb);
> count -= overflow;
> }
> - brelse(bitmap_bh);
> + put_bh(bitmap_bh);
Is it safe to always s/brelse/put_bh/ ? Or someone has to audit every
occurence for this "neelessly permits a NULL"?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: + ext3-and-jbd-cleanup-replace-brelse-to-put_bh.patch added to -mm tree
2006-08-14 22:59 ` + ext3-and-jbd-cleanup-replace-brelse-to-put_bh.patch added to -mm tree Alexey Dobriyan
@ 2006-08-14 23:16 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-08-14 23:16 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, cmm
On Tue, 15 Aug 2006 02:59:41 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Fri, Aug 11, 2006 at 06:46:13PM -0700, akpm@osdl.org wrote:
> > Replace all brelse() calls with put_bh(). Because brelse() is
> > old-fashioned, has a weird name and neelessly permits a NULL
>
> > --- a/fs/ext3/balloc.c~ext3-and-jbd-cleanup-replace-brelse-to-put_bh
> > +++ a/fs/ext3/balloc.c
> > @@ -351,7 +351,7 @@ do_more:
> > overflow = bit + count - EXT3_BLOCKS_PER_GROUP(sb);
> > count -= overflow;
> > }
> > - brelse(bitmap_bh);
> > + put_bh(bitmap_bh);
>
> Is it safe to always s/brelse/put_bh/ ? Or someone has to audit every
> occurence for this "neelessly permits a NULL"?
Yeah, it crashed all over the place.
I'd be inclined to give up on this idea. Life's too short.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-14 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200608120146.k7C1kDVd006044@shell0.pdx.osdl.net>
2006-08-14 22:59 ` + ext3-and-jbd-cleanup-replace-brelse-to-put_bh.patch added to -mm tree Alexey Dobriyan
2006-08-14 23:16 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®