From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org#,
dhowells@redhat.com
Subject: [RHEL5 PATCH 4/4] VFS: Fix 64-bit ino_t warning in CacheFiles facility
Date: Mon, 14 Aug 2006 22:15:14 +0100 [thread overview]
Message-ID: <20060814211514.27190.90014.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060814211504.27190.10491.stgit@warthog.cambridge.redhat.com>
Fix the print format warnings that occur in CacheFiles when ino_t is made
unsigned long long.
Signed-Off-By: David Howells <dhowells@redhat.com>
---
fs/cachefiles/cf-interface.c | 2 +-
fs/cachefiles/cf-namei.c | 14 +++++++-------
fs/cachefiles/cf-xattr.c | 16 ++++++++--------
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/fs/cachefiles/cf-interface.c b/fs/cachefiles/cf-interface.c
index b5ca30f..37d8973 100644
--- a/fs/cachefiles/cf-interface.c
+++ b/fs/cachefiles/cf-interface.c
@@ -428,7 +428,7 @@ void cachefiles_read_copier_work(void *_
struct pagevec pagevec;
int error, max;
- _enter("{ino=%lu}", object->backer->d_inode->i_ino);
+ _enter("{ino=%llu}", object->backer->d_inode->i_ino);
pagevec_init(&pagevec, 0);
diff --git a/fs/cachefiles/cf-namei.c b/fs/cachefiles/cf-namei.c
index 20db88a..76bf637 100644
--- a/fs/cachefiles/cf-namei.c
+++ b/fs/cachefiles/cf-namei.c
@@ -382,11 +382,11 @@ lookup_again:
fsnotify_mkdir(dir->d_inode, next);
- _debug("mkdir -> %p{%p{ino=%lu}}",
+ _debug("mkdir -> %p{%p{ino=%llu}}",
next, next->d_inode, next->d_inode->i_ino);
} else if (!S_ISDIR(next->d_inode->i_mode)) {
- kerror("inode %lu is not a directory",
+ kerror("inode %llu is not a directory",
next->d_inode->i_ino);
ret = -ENOBUFS;
goto error;
@@ -405,13 +405,13 @@ lookup_again:
fsnotify_create(dir->d_inode, next);
- _debug("create -> %p{%p{ino=%lu}}",
+ _debug("create -> %p{%p{ino=%llu}}",
next, next->d_inode, next->d_inode->i_ino);
} else if (!S_ISDIR(next->d_inode->i_mode) &&
!S_ISREG(next->d_inode->i_mode)
) {
- kerror("inode %lu is not a file or directory",
+ kerror("inode %llu is not a file or directory",
next->d_inode->i_ino);
ret = -ENOBUFS;
goto error;
@@ -497,7 +497,7 @@ lookup_again:
current->fsgid = fsgid;
object->new = 0;
- _leave(" = 0 [%lu]", object->dentry->d_inode->i_ino);
+ _leave(" = 0 [%llu]", object->dentry->d_inode->i_ino);
return 0;
create_error:
@@ -615,7 +615,7 @@ struct dentry *cachefiles_get_directory(
fsnotify_mkdir(dir->d_inode, subdir);
- _debug("mkdir -> %p{%p{ino=%lu}}",
+ _debug("mkdir -> %p{%p{ino=%llu}}",
subdir,
subdir->d_inode,
subdir->d_inode->i_ino);
@@ -647,7 +647,7 @@ struct dentry *cachefiles_get_directory(
!subdir->d_inode->i_op->unlink)
goto check_error;
- _leave(" = [%lu]", subdir->d_inode->i_ino);
+ _leave(" = [%llu]", subdir->d_inode->i_ino);
return subdir;
check_error:
diff --git a/fs/cachefiles/cf-xattr.c b/fs/cachefiles/cf-xattr.c
index 8952bf0..1baf4c8 100644
--- a/fs/cachefiles/cf-xattr.c
+++ b/fs/cachefiles/cf-xattr.c
@@ -57,7 +57,7 @@ int cachefiles_check_object_type(struct
}
if (ret != -EEXIST) {
- kerror("Can't set xattr on %*.*s [%lu] (err %d)",
+ kerror("Can't set xattr on %*.*s [%llu] (err %d)",
dentry->d_name.len, dentry->d_name.len,
dentry->d_name.name, dentry->d_inode->i_ino,
-ret);
@@ -71,7 +71,7 @@ int cachefiles_check_object_type(struct
if (ret == -ERANGE)
goto bad_type_length;
- kerror("Can't read xattr on %*.*s [%lu] (err %d)",
+ kerror("Can't read xattr on %*.*s [%llu] (err %d)",
dentry->d_name.len, dentry->d_name.len,
dentry->d_name.name, dentry->d_inode->i_ino,
-ret);
@@ -93,14 +93,14 @@ error:
return ret;
bad_type_length:
- kerror("Cache object %lu type xattr length incorrect",
+ kerror("Cache object %llu type xattr length incorrect",
dentry->d_inode->i_ino);
ret = -EIO;
goto error;
bad_type:
xtype[2] = 0;
- kerror("Cache object %*.*s [%lu] type %s not %s",
+ kerror("Cache object %*.*s [%llu] type %s not %s",
dentry->d_name.len, dentry->d_name.len,
dentry->d_name.name, dentry->d_inode->i_ino,
xtype, type);
@@ -184,7 +184,7 @@ int cachefiles_check_object_xattr(struct
goto bad_type_length;
cachefiles_io_error_obj(object,
- "can't read xattr on %lu (err %d)",
+ "can't read xattr on %llu (err %d)",
dentry->d_inode->i_ino, -ret);
goto error;
}
@@ -237,7 +237,7 @@ int cachefiles_check_object_xattr(struct
XATTR_REPLACE);
if (ret < 0) {
cachefiles_io_error_obj(object,
- "Can't update xattr on %lu"
+ "Can't update xattr on %llu"
" (error %d)",
dentry->d_inode->i_ino, -ret);
goto error;
@@ -254,7 +254,7 @@ error:
return ret;
bad_type_length:
- kerror("Cache object %lu xattr length incorrect",
+ kerror("Cache object %llu xattr length incorrect",
dentry->d_inode->i_ino);
ret = -EIO;
goto error;
@@ -285,7 +285,7 @@ int cachefiles_remove_object_xattr(struc
ret = 0;
else if (ret != -ENOMEM)
cachefiles_io_error(cache,
- "Can't remove xattr from %lu"
+ "Can't remove xattr from %llu"
" (error %d)",
dentry->d_inode->i_ino, -ret);
}
next prev parent reply other threads:[~2006-08-14 21:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 21:15 [PATCH 0/4] Use 64-bit inode numbers internally in the kernel David Howells
2006-08-14 21:15 ` [RHEL5 PATCH 1/4] Provide fallback full 64-bit divide/modulus ops for gcc David Howells
2006-08-15 6:44 ` Jan Engelhardt
2006-08-15 8:10 ` Andi Kleen
2006-08-15 8:29 ` David Howells
2006-08-18 8:39 ` Pavel Machek
2006-08-18 10:33 ` David Howells
2006-08-14 21:15 ` [RHEL5 PATCH 2/4] VFS: Make inode numbers 64-bits David Howells
2006-08-15 1:31 ` Al Viro
2006-08-15 6:48 ` Jan Engelhardt
2006-08-15 8:21 ` David Howells
2006-08-15 9:06 ` Al Viro
2006-08-15 8:32 ` David Howells
2006-08-15 9:02 ` Al Viro
2006-08-15 9:25 ` David Howells
2006-08-15 12:45 ` Stephen Rothwell
2006-08-14 21:15 ` [RHEL5 PATCH 3/4] VFS: Clear up u-long-long ino_t print format warnings David Howells
2006-08-14 21:15 ` David Howells [this message]
2006-08-15 0:36 ` [PATCH 0/4] Use 64-bit inode numbers internally in the kernel Josh Boyer
2006-08-15 8:21 ` David Howells
2006-08-15 9:13 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814211514.27190.90014.stgit@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org# \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®