mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org#
Subject: Re: [RHEL5 PATCH 1/4] Provide fallback full 64-bit divide/modulus ops for gcc
Date: Fri, 18 Aug 2006 08:39:12 +0000	[thread overview]
Message-ID: <20060818083911.GB7516@ucw.cz> (raw)
In-Reply-To: <7510.1155630597@warthog.cambridge.redhat.com>

On Tue 15-08-06 09:29:57, David Howells wrote:
> Andi Kleen <ak@suse.de> wrote:
> 
> > At least Linus' traditional argument against this is that it's better
> > to open code these (do_div) so that it's clear to the coder that they
> > are really costly.
> 
> do_div() is not a full replacement for __udivdi3(), __umoddi3() or
> __udivmoddi4(), though I suspect we don't need divisor >= 2^32 anywhere atm.
> 
> There are places where the compiler emits these that aren't entirely obvious,
> one of which IIRC is in ext2 inode allocation.

Well -- but that is good reason to keep that open-coded, right?

-- 
Thanks for all the (sleeping) penguins.

  reply	other threads:[~2006-08-18 10:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 21:15 [PATCH 0/4] Use 64-bit inode numbers internally in the kernel David Howells
2006-08-14 21:15 ` [RHEL5 PATCH 1/4] Provide fallback full 64-bit divide/modulus ops for gcc David Howells
2006-08-15  6:44   ` Jan Engelhardt
2006-08-15  8:10   ` Andi Kleen
2006-08-15  8:29   ` David Howells
2006-08-18  8:39     ` Pavel Machek [this message]
2006-08-18 10:33     ` David Howells
2006-08-14 21:15 ` [RHEL5 PATCH 2/4] VFS: Make inode numbers 64-bits David Howells
2006-08-15  1:31   ` Al Viro
2006-08-15  6:48   ` Jan Engelhardt
2006-08-15  8:21   ` David Howells
2006-08-15  9:06     ` Al Viro
2006-08-15  8:32   ` David Howells
2006-08-15  9:02     ` Al Viro
2006-08-15  9:25     ` David Howells
2006-08-15 12:45       ` Stephen Rothwell
2006-08-14 21:15 ` [RHEL5 PATCH 3/4] VFS: Clear up u-long-long ino_t print format warnings David Howells
2006-08-14 21:15 ` [RHEL5 PATCH 4/4] VFS: Fix 64-bit ino_t warning in CacheFiles facility David Howells
2006-08-15  0:36 ` [PATCH 0/4] Use 64-bit inode numbers internally in the kernel Josh Boyer
2006-08-15  8:21 ` David Howells
2006-08-15  9:13   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060818083911.GB7516@ucw.cz \
    --to=pavel@suse.cz \
    --cc=ak@suse.de \
    --cc=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org# \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®