* [PATCH] net/atm compile error on ARM
@ 2006-08-14 19:28 Kevin Hilman
2006-08-15 9:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hilman @ 2006-08-14 19:28 UTC (permalink / raw)
To: Linux-atm-general; +Cc: linux-kernel
atm_proc_exit() is declared as __exit, and thus in .exit.text. On
some architectures (ARM) .exit.text is discarded at compile time, and
since atm_proc_exit() is called by some other __init functions, it
results in a link error.
Signed-off-by: Kevin Hilman <khilman@mvista.com>
Index: ixp4xx/net/atm/proc.c
===================================================================
--- ixp4xx.orig/net/atm/proc.c
+++ ixp4xx/net/atm/proc.c
@@ -507,7 +507,7 @@ err_out:
goto out;
}
-void __exit atm_proc_exit(void)
+void atm_proc_exit(void)
{
atm_proc_dirs_remove();
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/atm compile error on ARM
2006-08-14 19:28 [PATCH] net/atm compile error on ARM Kevin Hilman
@ 2006-08-15 9:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-08-15 9:02 UTC (permalink / raw)
To: kevin; +Cc: Linux-atm-general, linux-kernel
From: Kevin Hilman <kevin@hilman.org>
Date: Mon, 14 Aug 2006 12:28:09 -0700
> atm_proc_exit() is declared as __exit, and thus in .exit.text. On
> some architectures (ARM) .exit.text is discarded at compile time, and
> since atm_proc_exit() is called by some other __init functions, it
> results in a link error.
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
Patch applied, thanks Kevin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-15 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-14 19:28 [PATCH] net/atm compile error on ARM Kevin Hilman
2006-08-15 9:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®