Re: [RFC] [PATCH] file posix capabilities

["Serge E. Hallyn" <serue@us.ibm.com>]

Quoting Casey Schaufler (casey@schaufler-ca.com):
> 
> 
> --- "Serge E. Hallyn" <serue@us.ibm.com> wrote:
> 
> 
> > +
> > +	bprm->cap_effective = fscaps[0];
> > +	bprm->cap_inheritable = fscaps[1];
> > +	bprm->cap_permitted = fscaps[2];
> > +
> 
> It does not appear that you're attempting
> to maintain the POSIX exec semantics for
> capability sets. (If you're doing it
> elsewhere in the code, nevermind) I don't
> know if this is intentional or not.

It should be getting done correctly at bprm_apply_creds.
The code you quote here is just setting it on the
binprm, which represents the executable itself (and as
pointed out in the comment above it).

Now the cap_bprm_secureexec() function needs to be
updated as I believe I pointed out in the original
submission.  But if anything else is not getting done
right please correct me.

> I will have a closer look, but just for
> grins, I've attached code from the SGI
> OB1 offering of some years back that
> includes a function, cap_recalc, that
> implements the correct behavior. I will
> also take a stab at working it in, but

Excellent, thanks.

> I expect someone will beat me to it.

-serge