Re: [Containers] [PATCH 2/7] pid: Add do_each_pid_task

["Serge E. Hallyn" <serue@us.ibm.com>]

Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serue@us.ibm.com> writes:
> 
> > Quoting Eric W. Biederman (ebiederm@xmission.com):
> >> To avoid pid rollover confusion the kernel needs to work with
> >> struct pid * instead of pid_t.  Currently there is not an iterator
> >> that walks through all of the tasks of a given pid type starting
> >> with a struct pid.  This prevents us replacing some pid_t instances
> >> with struct pid.  So this patch adds do_each_pid_task which walks
> >> through the set of task for a given pid type starting with a struct pid.
> >> 
> >> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> >> ---
> >>  include/linux/pid.h |   13 +++++++++++++
> >>  1 files changed, 13 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/include/linux/pid.h b/include/linux/pid.h
> >> index 93da7e2..4007114 100644
> >> --- a/include/linux/pid.h
> >> +++ b/include/linux/pid.h
> >> @@ -118,4 +118,17 @@ #define while_each_task_pid(who, type, t
> >>  				1; }) );				\
> >>  	}
> >>  
> >> +#define do_each_pid_task(pid, type, task)				\
> >
> > Hmm, defining do_each_pid_task right after do_each_task_pid could result
> > in some frustration  :)
> >
> > Though not sure of a better name - do_each_task_structpid?
> 
> A couple of things.
> -  I think do_each_pid_task is probably the most descriptive name
>    I can come up with.  As these are tasks of a pid.  I don't quite understand
>    where the old name came from.
> 
> - Whatever we pick for the new function is the name we are going to use
>   for a long time so I don't want it to be clumsy.  The existing function
>   will go away after everything is updated.

Ok.  If the old iterator is going away that's fine.

I was under the impression we'd still need to be able to do the loop
based on pid_t as well.

thanks,
-serge