From: Corey Minyard <minyard@acm.org>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Cc: Olaf Kirch <okir@suse.de>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: [PATCH] IPMI: fix occasional oops on module unload
Date: Wed, 30 Aug 2006 12:42:51 -0500 [thread overview]
Message-ID: <20060830174251.GA20983@localdomain> (raw)
Olaf Kirch of SuSE tracked down a problem where module unloads of
the IPMI driver would occasionally result in Oopses. He tracked
that down to a variable that wasn't always initialized properly
in some situations. This patch initializes that variable.
Olaf sent a patch that kzalloc-ed the data, but this structure
is large enough that I would perfer to not do that.
Thanks Olaf!
Signed-off-by: Corey Minyard <minyard@acm.org>
Cc: Olaf Kirch <okir@suse.de>
Index: linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- linux-2.6.17.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
@@ -3470,6 +3470,7 @@ struct ipmi_recv_msg *ipmi_alloc_recv_ms
rv = kmalloc(sizeof(struct ipmi_recv_msg), GFP_ATOMIC);
if (rv) {
+ rv->user = NULL;
rv->done = free_recv_msg;
atomic_inc(&recv_msg_inuse_count);
}
reply other threads:[~2006-08-30 17:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060830174251.GA20983@localdomain \
--to=minyard@acm.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okir@suse.de \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®