* [PATCH] IPMI: fix occasional oops on module unload
@ 2006-08-30 17:42 Corey Minyard
0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2006-08-30 17:42 UTC (permalink / raw)
To: Linux Kernel, Andrew Morton; +Cc: Olaf Kirch, OpenIPMI Developers
Olaf Kirch of SuSE tracked down a problem where module unloads of
the IPMI driver would occasionally result in Oopses. He tracked
that down to a variable that wasn't always initialized properly
in some situations. This patch initializes that variable.
Olaf sent a patch that kzalloc-ed the data, but this structure
is large enough that I would perfer to not do that.
Thanks Olaf!
Signed-off-by: Corey Minyard <minyard@acm.org>
Cc: Olaf Kirch <okir@suse.de>
Index: linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- linux-2.6.17.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
@@ -3470,6 +3470,7 @@ struct ipmi_recv_msg *ipmi_alloc_recv_ms
rv = kmalloc(sizeof(struct ipmi_recv_msg), GFP_ATOMIC);
if (rv) {
+ rv->user = NULL;
rv->done = free_recv_msg;
atomic_inc(&recv_msg_inuse_count);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-30 17:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-30 17:42 [PATCH] IPMI: fix occasional oops on module unload Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®