Re: [PATCH 2.6.18-rc5] PCI: sort device lists breadth-first

[Greg KH <greg@kroah.com>]

On Fri, Sep 08, 2006 at 11:56:39AM -0400, Dave Jones wrote:
> On Thu, Sep 07, 2006 at 10:14:22PM -0500, Matt Domsch wrote:
>  > Problem:
>  > New Dell PowerEdge servers have 2 embedded ethernet ports, which are
>  > labeled NIC1 and NIC2 on the chassis, in the BIOS setup screens, and
>  > in the printed documentation.  Assuming no other add-in ethernet ports
>  > in the system, Linux 2.4 kernels name these eth0 and eth1
>  > respectively.  Many people have come to expect this naming.  Linux 2.6
>  > kernels name these eth1 and eth0 respectively (backwards from
>  > expectations).  I also have reports that various Sun and HP servers
>  > have similar behavior.
>  
> This came up years back when 2.6 was something new, and the answer
> then was 'bind the interface to the MAC address'.

It came up then?  I don't recall it, if so, I hope I didn't say that...

We should fix this, it's obviously a regression.  Thanks a lot Matt for
tracking this down and fixing it.

> Whilst your patch will fix the case that's currently broken (2.4->2.6),
> doesn't it offer equal possibility to break existing setups when people move
> from <=2.6.18 -> 2.6.19 ?

It might, but I'll take that heat, we do have a command line option that
returns the functionality to the "broken" way.

Let's see what happens in the next -mm.

thanks,

greg k-h