mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [BUG/PATCH] make deb-pkg: optionally use fakeroot
@ 2006-09-08 18:53 Matthias Lederhofer
  2006-09-09  8:16 ` Jan Engelhardt
  2006-09-09 22:15 ` Matthias Lederhofer
  0 siblings, 2 replies; 3+ messages in thread
From: Matthias Lederhofer @ 2006-09-08 18:53 UTC (permalink / raw)
  To: Linux Kernel

Problem: deb-pkg needs root privileges or fakeroot but git-diff-index
does not work correctly with fakeroot.  Perhaps this variable should
have another name and be added to the other package targets too.

---
 scripts/package/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 7c434e0..d77e21a 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -72,7 +72,7 @@ # Deb target
 # ---------------------------------------------------------------------------
 deb-pkg: FORCE
 	$(MAKE) KBUILD_SRC=
-	$(CONFIG_SHELL) $(srctree)/scripts/package/builddeb
+	$(FAKEROOT) $(CONFIG_SHELL) $(srctree)/scripts/package/builddeb
 
 clean-dirs += $(objtree)/debian/
 
-- 
1.4.2.g0ea2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG/PATCH] make deb-pkg: optionally use fakeroot
  2006-09-08 18:53 [BUG/PATCH] make deb-pkg: optionally use fakeroot Matthias Lederhofer
@ 2006-09-09  8:16 ` Jan Engelhardt
  2006-09-09 22:15 ` Matthias Lederhofer
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Engelhardt @ 2006-09-09  8:16 UTC (permalink / raw)
  To: Matthias Lederhofer; +Cc: Linux Kernel


>diff --git a/scripts/package/Makefile b/scripts/package/Makefile
>index 7c434e0..d77e21a 100644
>--- a/scripts/package/Makefile
>+++ b/scripts/package/Makefile
>@@ -72,7 +72,7 @@ # Deb target
> # ---------------------------------------------------------------------------
> deb-pkg: FORCE
> 	$(MAKE) KBUILD_SRC=
>-	$(CONFIG_SHELL) $(srctree)/scripts/package/builddeb
>+	$(FAKEROOT) $(CONFIG_SHELL) $(srctree)/scripts/package/builddeb

Why are distribution-specific things/objects/targets even included?



Jan Engelhardt
-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG/PATCH] make deb-pkg: optionally use fakeroot
  2006-09-08 18:53 [BUG/PATCH] make deb-pkg: optionally use fakeroot Matthias Lederhofer
  2006-09-09  8:16 ` Jan Engelhardt
@ 2006-09-09 22:15 ` Matthias Lederhofer
  1 sibling, 0 replies; 3+ messages in thread
From: Matthias Lederhofer @ 2006-09-09 22:15 UTC (permalink / raw)
  To: Linux Kernel

Matthias Lederhofer <matled@gmx.net> wrote:
> Problem: deb-pkg needs root privileges or fakeroot but git-diff-index
> does not work correctly with fakeroot.  Perhaps this variable should
> have another name and be added to the other package targets too.

<gitster> So "fakeroot -u" (Use the real ownership of files previously
    unknown to fakeroot instead of pretending they are owned by
    root:root.) would be a good workaround.
<gitster> Eh, not a workaround but probably that is the right thing to do.

This solves the problem, just ignore the patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-09-09 22:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-08 18:53 [BUG/PATCH] make deb-pkg: optionally use fakeroot Matthias Lederhofer
2006-09-09  8:16 ` Jan Engelhardt
2006-09-09 22:15 ` Matthias Lederhofer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome