* [PATCH] SELinux: Fix bug in security_sid_mls_copy
@ 2006-09-19 13:47 James Morris
2006-09-19 14:03 ` James Morris
0 siblings, 1 reply; 3+ messages in thread
From: James Morris @ 2006-09-19 13:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: Stephen Smalley, linux-kernel, Venkat Yekkirala
From: Venkat Yekkirala <vyekkirala@TrustedCS.com>
The following fixes a bug where random mem is being tampered with in the
non-mls case; encountered by Jashua Brindle on a gentoo box.
Please apply.
Signed-off-by: Venkat Yekkirala <vyekkirala@TrustedCS.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: James Morris <jmorris@namei.org>
---
security/selinux/ss/services.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 27ee28c..7eb69a6 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1841,7 +1841,7 @@ int security_sid_mls_copy(u32 sid, u32 m
u32 len;
int rc = 0;
- if (!ss_initialized) {
+ if (!ss_initialized || !selinux_mls_enabled) {
*new_sid = sid;
goto out;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] SELinux: Fix bug in security_sid_mls_copy
2006-09-19 13:47 [PATCH] SELinux: Fix bug in security_sid_mls_copy James Morris
@ 2006-09-19 14:03 ` James Morris
2006-09-19 17:24 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: James Morris @ 2006-09-19 14:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: Stephen Smalley, linux-kernel, Venkat Yekkirala
On Tue, 19 Sep 2006, James Morris wrote:
> From: Venkat Yekkirala <vyekkirala@TrustedCS.com>
>
> The following fixes a bug where random mem is being tampered with in the
> non-mls case; encountered by Jashua Brindle on a gentoo box.
>
> Please apply.
Actually, don't. It's for the net-2.6.19 tree.
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SELinux: Fix bug in security_sid_mls_copy
2006-09-19 14:03 ` James Morris
@ 2006-09-19 17:24 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2006-09-19 17:24 UTC (permalink / raw)
To: jmorris; +Cc: akpm, sds, linux-kernel, vyekkirala
From: James Morris <jmorris@namei.org>
Date: Tue, 19 Sep 2006 10:03:30 -0400 (EDT)
> On Tue, 19 Sep 2006, James Morris wrote:
>
> > From: Venkat Yekkirala <vyekkirala@TrustedCS.com>
> >
> > The following fixes a bug where random mem is being tampered with in the
> > non-mls case; encountered by Jashua Brindle on a gentoo box.
> >
> > Please apply.
>
> Actually, don't. It's for the net-2.6.19 tree.
Applied to net-2.6.19, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-19 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-19 13:47 [PATCH] SELinux: Fix bug in security_sid_mls_copy James Morris
2006-09-19 14:03 ` James Morris
2006-09-19 17:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®