* [PATCH] SCSI: shift device_reprobe() warning explosion
@ 2006-09-28 1:08 Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2006-09-28 1:08 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-scsi
SCSI warns about device_reprobe() for _every file_, even though there is
only a single caller in the entirety of SCSI.
The need to check return code is valid, so we update the warning area to
shift the burden to the [only] caller, mptsas.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 895d212..b401c82 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -298,9 +298,9 @@ extern int scsi_execute_async(struct scs
void (*done)(void *, char *, int, int),
gfp_t gfp);
-static inline void scsi_device_reprobe(struct scsi_device *sdev)
+static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev)
{
- device_reprobe(&sdev->sdev_gendev);
+ return device_reprobe(&sdev->sdev_gendev);
}
static inline unsigned int sdev_channel(struct scsi_device *sdev)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-09-28 1:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-28 1:08 [PATCH] SCSI: shift device_reprobe() warning explosion Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®