mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [S390] Avoid static struct initializations in appldata.
@ 2006-09-28 13:07 Martin Schwidefsky
  0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2006-09-28 13:07 UTC (permalink / raw)
  To: linux-kernel, geraldsc

From: Gerald Schaefer <geraldsc@de.ibm.com>

[S390] Avoid static struct initializations in appldata.

Don't use static initialization for struct members containing
variables because gcc would generate more code and use double space
on stack.

Signed-off-by: Gerald Schaefer <geraldsc@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 arch/s390/appldata/appldata_base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -urpN linux-2.6/arch/s390/appldata/appldata_base.c linux-2.6-patched/arch/s390/appldata/appldata_base.c
--- linux-2.6/arch/s390/appldata/appldata_base.c	2006-09-28 14:58:39.000000000 +0200
+++ linux-2.6-patched/arch/s390/appldata/appldata_base.c	2006-09-28 14:58:50.000000000 +0200
@@ -157,12 +157,12 @@ int appldata_diag(char record_nr, u16 fu
 		.prod_nr    = {0xD3, 0xC9, 0xD5, 0xE4,
 			       0xE7, 0xD2, 0xD9},	/* "LINUXKR" */
 		.prod_fn    = 0xD5D3,			/* "NL" */
-		.record_nr  = record_nr,
 		.version_nr = 0xF2F6,			/* "26" */
 		.release_nr = 0xF0F1,			/* "01" */
-		.mod_lvl    = (mod_lvl[0]) << 8 | mod_lvl[1],
 	};
 
+	id.record_nr = record_nr;
+	id.mod_lvl = (mod_lvl[0]) << 8 | mod_lvl[1];
 	return appldata_asm(&id, function, (void *) buffer, length);
 }
 /************************ timer, work, DIAG <END> ****************************/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-09-28 13:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-28 13:07 [S390] Avoid static struct initializations in appldata Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome