From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jaroslav Kysela <perex@suse.cz>, Andrew Morton <akpm@osdl.org>,
ALSA development <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>, Greg KH <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>, Jiri Kosina <jikos@jikos.cz>,
Castet Matthieu <castet.matthieu@free.fr>
Subject: Re: [Alsa-devel] [PATCH] Driver core: Don't ignore error returns from probing
Date: Mon, 9 Oct 2006 13:10:12 +0200 [thread overview]
Message-ID: <20061009131012.3ba21242@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0610061400180.1311-100000@netrider.rowland.org>
On Fri, 6 Oct 2006 14:12:49 -0400 (EDT),
Alan Stern <stern@rowland.harvard.edu> wrote:
> I'm still not sure why bus_attach_device() was split off from
> bus_add_device() in the first place. Was it just so that the
> kobject_uevent() call could go in between?
I think yes. This was added in
http://marc.theaimsgroup.com/?l=linux-kernel&m=115092084915731&w=2
> This looks okay, but it would be better if bus_remove_device() did not
> directly call bus_delete_device(). Just add an extra call inside
> device_del(), so that everything remains symmetrical.
>
> While I'm harping on style issues, you should also capitalize AttachError
> so that it matches the form of the other statement labels nearby. And in
> bus_remove_device() you should put all the code inside the "if" block
> instead of returning when dev->bus isn't set, just as the neighboring
> subroutines do.
OK, new patch on the way.
--
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
next prev parent reply other threads:[~2006-10-09 11:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 20:22 [PATCH] ALSA: fix kernel panic in initialization of mpu401 driver Jiri Kosina
2006-10-05 8:07 ` Jaroslav Kysela
2006-10-05 9:57 ` Jiri Kosina
2006-10-05 14:02 ` Alan Stern
2006-10-05 14:16 ` Jaroslav Kysela
2006-10-05 17:58 ` Greg KH
2006-10-05 21:03 ` [PATCH] Driver core: Don't ignore error returns from probing Alan Stern
2006-10-06 7:53 ` Cornelia Huck
2006-10-06 7:57 ` [PATCH] driver core: bus_attach_device() retval check Cornelia Huck
2006-10-06 9:41 ` [Alsa-devel] [PATCH] Driver core: Don't ignore error returns from probing Jaroslav Kysela
2006-10-06 11:14 ` Cornelia Huck
2006-10-06 11:46 ` Jaroslav Kysela
2006-10-06 18:12 ` Alan Stern
2006-10-09 11:10 ` Cornelia Huck [this message]
2006-10-09 11:14 ` [PATCH] Driver core: Don't ignore bus_attach_device() retval Cornelia Huck
2006-10-09 14:10 ` Alan Stern
2006-10-11 14:49 ` Alan Stern
2006-10-12 9:30 ` Cornelia Huck
2006-10-12 15:59 ` Alan Stern
2006-10-12 17:17 ` Cornelia Huck
2006-10-12 21:41 ` Alan Stern
2006-10-13 6:37 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009131012.3ba21242@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=castet.matthieu@free.fr \
--cc=gregkh@suse.de \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®