* RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl
@ 2006-10-10 6:00 Noguchi, Masato
2006-10-10 8:11 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Noguchi, Masato @ 2006-10-10 6:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Paul Mackerras, Arnd Bergmann, linuxppc-dev, cbe-oss-dev, linux-kernel
After applying these patches, it seems the kernel leaks memory.
No doubt you forget to call simple_attr_close on "[PATCH 09/14]
spufs: add support for read/write oncntl".
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
---
Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .close = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl
2006-10-10 6:00 [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl Noguchi, Masato
@ 2006-10-10 8:11 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2006-10-10 8:11 UTC (permalink / raw)
To: Noguchi, Masato; +Cc: Paul Mackerras, linuxppc-dev, cbe-oss-dev, linux-kernel
On Tuesday 10 October 2006 08:00, Noguchi, Masato wrote:
> After applying these patches, it seems the kernel leaks memory.
> No doubt you forget to call simple_attr_close on "[PATCH 09/14]
> spufs: add support for read/write oncntl".
Ok, thanks for pointing this out.
> Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Paul, please apply.
Arnd <><
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl
@ 2006-10-10 6:49 Noguchi, Masato
0 siblings, 0 replies; 3+ messages in thread
From: Noguchi, Masato @ 2006-10-10 6:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Paul Mackerras, Arnd Bergmann, linuxppc-dev, cbe-oss-dev, linux-kernel
Oops,
I'm so sorry. I mistake to send wrong patch.
Correct version is below:
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
---
Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .release = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,
> -----Original Message-----
> From: Noguchi, Masato
> Sent: Tuesday, October 10, 2006 3:00 PM
> To: 'Arnd Bergmann'
> Cc: Paul Mackerras; Arnd Bergmann; linuxppc-dev@ozlabs.org;
> cbe-oss-dev@ozlabs.org; linux-kernel@vger.kernel.org
> Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for
read/write
> oncntl
>
> After applying these patches, it seems the kernel leaks memory.
> No doubt you forget to call simple_attr_close on "[PATCH 09/14]
> spufs: add support for read/write oncntl".
>
> Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
>
> ---
>
> Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> ===================================================================
> ---
>
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
> +++
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
>
> static struct file_operations spufs_cntl_fops = {
> .open = spufs_cntl_open,
> + .close = simple_attr_close,
> .read = simple_attr_read,
> .write = simple_attr_write,
> .mmap = spufs_cntl_mmap,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-10 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 6:00 [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl Noguchi, Masato
2006-10-10 8:11 ` Arnd Bergmann
2006-10-10 6:49 Noguchi, Masato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®