* Potential fix for fdtable badness.
@ 2006-10-11 2:08 Vadim Lobanov
2006-10-11 2:31 ` Andrew Morton
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Vadim Lobanov @ 2006-10-11 2:08 UTC (permalink / raw)
To: Dave Kleikamp, Olof Johansson, Linas Vepstas, Bryce Harrington,
Andrew Morton
Cc: linux-kernel
All,
Sorry about the recent fdtable badness that you all encountered. I'm working
on getting a fix out there.
Dave, Olof, Linas, Bryce,
Could you please test the patch at the bottom of the email to see if it makes
your computers happy again, if you have the time and inclination to do so?
Andrew,
Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top of
what's in your tree?
diff -Npru old/fs/file.c new/fs/file.c
--- old/fs/file.c 2006-10-10 18:58:21.000000000 -0700
+++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
@@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
* the fdarray into page-sized chunks: starting at a quarter of a page,
* and growing in powers of two from there on.
*/
- nr++;
nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
- nr = roundup_pow_of_two(nr);
+ nr = roundup_pow_of_two(nr + 1);
nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
if (nr > NR_OPEN)
nr = NR_OPEN;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Potential fix for fdtable badness.
2006-10-11 2:08 Potential fix for fdtable badness Vadim Lobanov
@ 2006-10-11 2:31 ` Andrew Morton
2006-10-11 2:39 ` Vadim Lobanov
2006-10-11 12:42 ` Dave Kleikamp
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2006-10-11 2:31 UTC (permalink / raw)
To: Vadim Lobanov
Cc: Dave Kleikamp, Olof Johansson, Linas Vepstas, Bryce Harrington,
linux-kernel
On Tue, 10 Oct 2006 19:08:18 -0700
Vadim Lobanov <vlobanov@speakeasy.net> wrote:
> Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top of
> what's in your tree?
Incremental updates are preferred.
> diff -Npru old/fs/file.c new/fs/file.c
> --- old/fs/file.c 2006-10-10 18:58:21.000000000 -0700
> +++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
> @@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
> * the fdarray into page-sized chunks: starting at a quarter of a page,
> * and growing in powers of two from there on.
> */
> - nr++;
> nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> - nr = roundup_pow_of_two(nr);
> + nr = roundup_pow_of_two(nr + 1);
> nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
> if (nr > NR_OPEN)
> nr = NR_OPEN;
Like that.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Potential fix for fdtable badness.
2006-10-11 2:31 ` Andrew Morton
@ 2006-10-11 2:39 ` Vadim Lobanov
0 siblings, 0 replies; 6+ messages in thread
From: Vadim Lobanov @ 2006-10-11 2:39 UTC (permalink / raw)
To: Andrew Morton
Cc: Dave Kleikamp, Olof Johansson, Linas Vepstas, Bryce Harrington,
linux-kernel
On Tuesday 10 October 2006 19:31, Andrew Morton wrote:
> On Tue, 10 Oct 2006 19:08:18 -0700
>
> Vadim Lobanov <vlobanov@speakeasy.net> wrote:
> > Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top
> > of what's in your tree?
>
> Incremental updates are preferred.
>
> > diff -Npru old/fs/file.c new/fs/file.c
> > --- old/fs/file.c 2006-10-10 18:58:21.000000000 -0700
> > +++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
> > @@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
> > * the fdarray into page-sized chunks: starting at a quarter of a page,
> > * and growing in powers of two from there on.
> > */
> > - nr++;
> > nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> > - nr = roundup_pow_of_two(nr);
> > + nr = roundup_pow_of_two(nr + 1);
> > nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
> > if (nr > NR_OPEN)
> > nr = NR_OPEN;
>
> Like that.
I'll wrap the fixes up in incremental patches once the problem has been
eradicated.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Potential fix for fdtable badness.
2006-10-11 2:08 Potential fix for fdtable badness Vadim Lobanov
2006-10-11 2:31 ` Andrew Morton
@ 2006-10-11 12:42 ` Dave Kleikamp
2006-10-11 17:10 ` Olof Johansson
2006-10-11 20:13 ` Linas Vepstas
3 siblings, 0 replies; 6+ messages in thread
From: Dave Kleikamp @ 2006-10-11 12:42 UTC (permalink / raw)
To: Vadim Lobanov
Cc: Olof Johansson, Linas Vepstas, Bryce Harrington, Andrew Morton,
linux-kernel
On Tue, 2006-10-10 at 19:08 -0700, Vadim Lobanov wrote:
> All,
>
> Sorry about the recent fdtable badness that you all encountered. I'm working
> on getting a fix out there.
>
> Dave, Olof, Linas, Bryce,
>
> Could you please test the patch at the bottom of the email to see if it makes
> your computers happy again, if you have the time and inclination to do so?
The patch works for me. Thanks!
Shaggy
> Andrew,
>
> Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top of
> what's in your tree?
>
> diff -Npru old/fs/file.c new/fs/file.c
> --- old/fs/file.c 2006-10-10 18:58:21.000000000 -0700
> +++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
> @@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
> * the fdarray into page-sized chunks: starting at a quarter of a page,
> * and growing in powers of two from there on.
> */
> - nr++;
> nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> - nr = roundup_pow_of_two(nr);
> + nr = roundup_pow_of_two(nr + 1);
> nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
> if (nr > NR_OPEN)
> nr = NR_OPEN;
--
David Kleikamp
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Potential fix for fdtable badness.
2006-10-11 2:08 Potential fix for fdtable badness Vadim Lobanov
2006-10-11 2:31 ` Andrew Morton
2006-10-11 12:42 ` Dave Kleikamp
@ 2006-10-11 17:10 ` Olof Johansson
2006-10-11 20:13 ` Linas Vepstas
3 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2006-10-11 17:10 UTC (permalink / raw)
To: Vadim Lobanov
Cc: Dave Kleikamp, Linas Vepstas, Bryce Harrington, Andrew Morton,
linux-kernel
On Tue, 10 Oct 2006 19:08:18 -0700 Vadim Lobanov <vlobanov@speakeasy.net> wrote:
> All,
>
> Sorry about the recent fdtable badness that you all encountered. I'm working
> on getting a fix out there.
>
> Dave, Olof, Linas, Bryce,
>
> Could you please test the patch at the bottom of the email to see if it makes
> your computers happy again, if you have the time and inclination to do so?
Looks good to me.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Potential fix for fdtable badness.
2006-10-11 2:08 Potential fix for fdtable badness Vadim Lobanov
` (2 preceding siblings ...)
2006-10-11 17:10 ` Olof Johansson
@ 2006-10-11 20:13 ` Linas Vepstas
3 siblings, 0 replies; 6+ messages in thread
From: Linas Vepstas @ 2006-10-11 20:13 UTC (permalink / raw)
To: Vadim Lobanov
Cc: Dave Kleikamp, Olof Johansson, Bryce Harrington, Andrew Morton,
linux-kernel
On Tue, Oct 10, 2006 at 07:08:18PM -0700, Vadim Lobanov wrote:
>
> Dave, Olof, Linas, Bryce,
>
> Could you please test the patch at the bottom of the email to see if it makes
> your computers happy again, if you have the time and inclination to do so?
>
> +++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
> - nr++;
> nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> - nr = roundup_pow_of_two(nr);
> + nr = roundup_pow_of_two(nr + 1);
This fixed things for me!
--linas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-11 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-11 2:08 Potential fix for fdtable badness Vadim Lobanov
2006-10-11 2:31 ` Andrew Morton
2006-10-11 2:39 ` Vadim Lobanov
2006-10-11 12:42 ` Dave Kleikamp
2006-10-11 17:10 ` Olof Johansson
2006-10-11 20:13 ` Linas Vepstas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®