Re: Linux ISO-9660 Rock Ridge bug needs fix

[Luca Tettamanti <kronos.it@gmail.com>]

Il Tue, Oct 17, 2006 at 08:16:07PM +0200, Joerg Schilling ha scritto: 
> Ismail Donmez <ismail@pardus.org.tr> wrote:
> 
> > I was just trying a fast hack to see it works ;-) but iso files produced by 
> > latest mkisofs works fine even without patching.
> 
> Did you _really_ use the latest mkisofs?

Yes, of course. As I said, the size of PX record is different:

000b820: 0100 5350 0701 beef 0052 5205 0181 5058  ..SP.....RR...PX
000b830: 2c01 6d41 0000 0000 416d 0200 0000 0000  ,.mA....Am......
         ^^ size is 44

but isofs (I'm using 2.6.19-rc2) doesn't care. If I'm reading the code
correctly record size is validated against (dentry size - name len -
records already parsed); it may be possibile to trigger the failure with
a certain combination of records (directory relocation?).
With my patch it should never happens that expected attributes size is
greater than dentry size.
Anyway, if you have a (small) image that triggers the error I can double
check the code.


Luca
-- 
#include <stdio.h> 
int main(void) {printf("\t\t\b\b\b\b\b\b");
printf("\t\t\b\b\b\b\b\b");return 0;}