mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@elstempel.de>
To: Luca Tettamanti <kronos.it@gmail.com>,
	linux-kernel@vger.kernel.org,
	Ismail Donmez <ismail@pardus.org.tr>,
	Joerg Schilling <schilling@fokus.fraunhofer.de>
Subject: Re: Linux ISO-9660 Rock Ridge bug needs fix
Date: Wed, 18 Oct 2006 01:09:37 +0200	[thread overview]
Message-ID: <E1GZy4L-00015O-AV@be1.lrz> (raw)
In-Reply-To: <771yn-1XU-65@gated-at.bofh.it>

Luca Tettamanti <kronos.it@gmail.com> wrote:

> +++ b/fs/isofs/rock.c

> +
> +                     /* Rock Ridge V1.12, override inode number */
> +                     if (rr->len == 44)
> +                             inode->i_ino = isonum_733(rr->u.PX.inode);

I think it's wrong again, it will break as soon as rockridge 1.13 defines
an additional field. s,==,>=, should do the trick.

BTW and without digging in the code: Since version 2 will be binary
incompatible, is there a version check?

BTW2, Just to be cautionous: what will happen if somebody forces the same
inode number on two different entries?
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html

       reply	other threads:[~2006-10-17 23:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <771eN-VK-9@gated-at.bofh.it>
     [not found] ` <771yn-1XU-65@gated-at.bofh.it>
2006-10-17 23:09   ` Bodo Eggert [this message]
2006-10-18 15:14     ` Joerg Schilling
2006-10-18 22:45       ` Bodo Eggert
2006-10-18 23:29         ` Joerg Schilling
2006-10-19 21:16           ` Bodo Eggert
2006-10-19 21:39             ` Joerg Schilling
2006-10-19 21:49               ` Alan Cox
2006-10-17 14:45 Joerg Schilling
2006-10-17 17:41 ` Ismail Donmez
2006-10-17 18:02   ` Luca Tettamanti
2006-10-17 18:14     ` Ismail Donmez
2006-10-17 18:16       ` Joerg Schilling
2006-10-17 18:32         ` Ismail Donmez
2006-10-17 19:50         ` Luca Tettamanti
2006-10-17 19:38     ` Pekka Enberg
2006-10-19 21:31       ` H. Peter Anvin
2006-10-17 18:12   ` Joerg Schilling
2006-10-17 18:28     ` Ismail Donmez
2006-10-17 18:32       ` Joerg Schilling
2006-10-17 18:39         ` Ismail Donmez
2006-10-17 21:07         ` James Lamanna
2006-10-17 21:32           ` Joerg Schilling
2006-10-17 21:51             ` James Lamanna
2006-10-17 22:24               ` Joerg Schilling
2006-10-17 23:06                 ` Alan Cox
2006-10-18 15:07                 ` Joerg Schilling
2006-10-17 19:53       ` Jan Engelhardt
2006-10-17 18:37 ` James Lamanna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1GZy4L-00015O-AV@be1.lrz \
    --to=7eggert@elstempel.de \
    --cc=7eggert@gmx.de \
    --cc=ismail@pardus.org.tr \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schilling@fokus.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®