* sysrq-t broke in -mm : sysrq-x-show-blocked-tasks.patch needs fixing
@ 2006-10-20 8:17 Neil Brown
2006-10-20 8:40 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Neil Brown @ 2006-10-20 8:17 UTC (permalink / raw)
To: Ingo Molnar, Andrew Morton; +Cc: linux-kernel
There is a test in the above mentioned patch in -mm that is backwards,
so
echo t > /proc/sysrq-trigger
stopped working.
echo p > /proc/sysrq-trigger isn't working on my x86-64 either just at
the moment, but that must be something else...
NeilBrown
diff .prev/kernel/sched.c ./kernel/sched.c
--- .prev/kernel/sched.c 2006-10-20 18:01:12.000000000 +1000
+++ ./kernel/sched.c 2006-10-20 18:01:22.000000000 +1000
@@ -4825,7 +4825,7 @@ void show_state_filter(unsigned long sta
* console might take alot of time:
*/
touch_nmi_watchdog();
- if (state_filter && (p->state & state_filter))
+ if (state_filter == 0 || (p->state & state_filter))
show_task(p);
} while_each_thread(g, p);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sysrq-t broke in -mm : sysrq-x-show-blocked-tasks.patch needs fixing
2006-10-20 8:17 sysrq-t broke in -mm : sysrq-x-show-blocked-tasks.patch needs fixing Neil Brown
@ 2006-10-20 8:40 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-10-20 8:40 UTC (permalink / raw)
To: Neil Brown; +Cc: Ingo Molnar, linux-kernel
On Fri, 20 Oct 2006 18:17:52 +1000
Neil Brown <neilb@suse.de> wrote:
>
> There is a test in the above mentioned patch in -mm that is backwards,
> so
> echo t > /proc/sysrq-trigger
> stopped working.
> echo p > /proc/sysrq-trigger isn't working on my x86-64 either just at
> the moment, but that must be something else...
yup, thanks. Should be fixed in mm2, which is but moments away...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-20 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-20 8:17 sysrq-t broke in -mm : sysrq-x-show-blocked-tasks.patch needs fixing Neil Brown
2006-10-20 8:40 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®