From: Al Viro <viro@ftp.linux.org.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] semaphore.h: add missing "sleepers = 0" initialization
Date: Mon, 30 Oct 2006 10:54:51 +0000 [thread overview]
Message-ID: <20061030105451.GN29920@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0610300540140.7056@localhost.localdomain>
On Mon, Oct 30, 2006 at 05:43:14AM -0500, Robert P. J. Day wrote:
>
> Add the missing initialization of "sleepers" to 0 in two semaphore
> initialization macros.
Umm... What the hell for? Both for struct initializer and for
compound literals all named fields that had not been mentioned
get initialized as they would for static objects. So that's
simply adding more work to parser for no reason whatsoever.
There are only two cases when something is left uninitialized:
* auto variable with no initializer whatsoever
* padding and unnamed members
That's it.
next prev parent reply other threads:[~2006-10-30 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 10:43 Robert P. J. Day
2006-10-30 10:54 ` Al Viro [this message]
2006-10-30 12:03 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030105451.GN29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®