mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [PATCH] semaphore.h: add missing "sleepers = 0" initialization
Date: Mon, 30 Oct 2006 07:03:10 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0610300659370.7577@localhost.localdomain> (raw)
In-Reply-To: <20061030105451.GN29920@ftp.linux.org.uk>

On Mon, 30 Oct 2006, Al Viro wrote:

> On Mon, Oct 30, 2006 at 05:43:14AM -0500, Robert P. J. Day wrote:
> >
> >   Add the missing initialization of "sleepers" to 0 in two semaphore
> > initialization macros.
>
> Umm...  What the hell for?  Both for struct initializer and for
> compound literals all named fields that had not been mentioned get
> initialized as they would for static objects.  So that's simply
> adding more work to parser for no reason whatsoever.

i did that simply to make those initializations *consistent* across
all of the other dozen or so semaphore.h files that *do* explicitly
initialize that structure member (as you point out, for no good
reason).  i'm just as happy to whack out all of those useless
initializations, though, and submit another patch.  either way works
for me.

rday

      reply	other threads:[~2006-10-30 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-30 10:43 Robert P. J. Day
2006-10-30 10:54 ` Al Viro
2006-10-30 12:03   ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0610300659370.7577@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®