Re: + lkdtm-module_param-fixes.patch added to -mm tree

Re: + lkdtm-module_param-fixes.patch added to -mm tree

[Randy Dunlap]

On Tue, 31 Oct 2006 00:37:59 -0800 akpm@osdl.org wrote:

This patch is even cleaner:
http://lkml.org/lkml/2006/10/23/390

Did you drop it?  never see/have it?


> ------------------------------------------------------
> Subject: lkdtm: module_param fixes
> From: Andrew Morton <akpm@osdl.org>
> 
> A assume these permissions were a typo - Alexey's
> compile-time-check-re-world-writeable-module-params.patch catches it.
> 
> Fix a typo in the help string too.
> 
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Ankita Garg <ankita@in.ibm.com>
> Cc: Vivek Goyal <vgoyal@in.ibm.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  drivers/misc/lkdtm.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff -puN drivers/misc/lkdtm.c~lkdtm-module_param-fixes drivers/misc/lkdtm.c
> --- a/drivers/misc/lkdtm.c~lkdtm-module_param-fixes
> +++ a/drivers/misc/lkdtm.c
> @@ -116,14 +116,14 @@ static enum ctype cptype = NONE;
>  static int count = DEFAULT_COUNT;
>  
>  module_param(recur_count, int, 0644);
> -MODULE_PARM_DESC(recur_count, "Recurcion level for the stack overflow test,\
> +MODULE_PARM_DESC(recur_count, "Recursion level for the stack overflow test,\
>  				 default is 10");
>  module_param(cpoint_name, charp, 0644);
>  MODULE_PARM_DESC(cpoint_name, "Crash Point, where kernel is to be crashed");
> -module_param(cpoint_type, charp, 06444);
> +module_param(cpoint_type, charp, 0644);
>  MODULE_PARM_DESC(cpoint_type, "Crash Point Type, action to be taken on\
>  				hitting the crash point");
> -module_param(cpoint_count, int, 06444);
> +module_param(cpoint_count, int, 0644);
>  MODULE_PARM_DESC(cpoint_count, "Crash Point Count, number of times the \
>  				crash point is to be hit to trigger action");

---
~Randy