From: Prakash Punnoor <prakash@punnoor.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Peer Chen <pchen@nvidia.com>,
jeff@garzik.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, Kuan Luo <kluo@nvidia.com>
Subject: Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c
Date: Tue, 31 Oct 2006 13:37:27 +0100 [thread overview]
Message-ID: <200610311337.27495.prakash@punnoor.de> (raw)
In-Reply-To: <20061031104055.GA8898@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
Am Dienstag 31 Oktober 2006 11:40 schrieb Christoph Hellwig:
> On Tue, Oct 31, 2006 at 04:43:19PM +0800, Peer Chen wrote:
> > + u32 cb_add, temp32;
> > + struct device *dev = pci_dev_to_dev(pdev);
> > + struct ata_host_set *host_set = dev_get_drvdata(dev);
> > + u8 pro=0;
> > + if (!(pro&0x40))
> > + return;
> > +
> > + temp32 = csr_add;
> > + phost->host_sgpio.pcsr = (void *)temp32;
> > + phost->host_sgpio.pcb = phys_to_virt(cb_add);
>
> Use of phys_to_virt is generally a bug. What are you trying to do here?
I am also wondering whether casting of temp32 to a pointer is very 64bit
friendly? At least my compiler on x86_64 gives a warning...
I also found
http://lkml.org/lkml/2006/8/21/324
which looks alike at first glance and it seems NVidia didn't really fix what
Andrew Morton told them to do so...
Cheers,
--
(°= =°)
//\ Prakash Punnoor /\\
V_/ \_V
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-10-31 12:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15F501D1A78BD343BE8F4D8DB854566B059FE0B3@hkemmail01.nvidia.com>
2006-10-31 8:43 ` Peer Chen
2006-10-31 10:40 ` Christoph Hellwig
2006-10-31 12:37 ` Prakash Punnoor [this message]
2006-11-07 9:55 ` Peer Chen
2007-11-07 4:09 ` Yinghai Lu
2009-01-18 9:20 ` Yinghai Lu
2009-01-18 9:22 ` [PATCH] sata_nv: sgpio for nvidia mcp55 Yinghai Lu
2009-01-21 2:07 ` [PATCH] sata_nv: sgpio for nvidia mcp55 -v2 Yinghai Lu
2009-01-22 2:32 ` [PATCH] sata_nv: sgpio for nvidia mcp55 -v3 Yinghai Lu
2009-01-27 4:57 ` Andrew Morton
2009-04-13 8:18 ` Jeff Garzik
2009-04-13 15:50 ` Yinghai Lu
2006-11-01 1:39 ` [PATCH] SCSI: Add the SGPIO support for sata_nv.c Jeff Garzik
2006-11-17 8:36 Peer Chen
2006-11-17 15:06 ` Heikki Orsila
2006-11-17 18:04 ` Jeff Garzik
2006-11-20 2:20 ` Peer Chen
2007-01-31 23:21 ` Kristen Carlson Accardi
2007-02-01 19:55 ` Andy Currid
2007-02-01 21:49 ` Kristen Carlson Accardi
[not found] <45A377D2.60401@garzik.org>
2007-01-10 2:50 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610311337.27495.prakash@punnoor.de \
--to=prakash@punnoor.de \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®