From: Heikki Orsila <shd@zakalwe.fi>
To: Peer Chen <pchen@nvidia.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Prakash Punnoor <prakash@punnoor.de>,
Andrew Morton <akpm@osdl.org>,
jeff@garzik.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, Kuan Luo <kluo@nvidia.com>
Subject: Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c
Date: Fri, 17 Nov 2006 17:06:12 +0200 [thread overview]
Message-ID: <20061117150612.GC12227@zakalwe.fi> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B0CEB90E0@hkemmail01.nvidia.com>
On Fri, Nov 17, 2006 at 04:36:37PM +0800, Peer Chen wrote:
> I didn't get any comment from you guys for new patch, does someone take
> care this patch, do we still need some modification upon it? Or do we
> need re-submit it in other thread?
One small change suggestion:
> +static inline bool nv_sgpio_capable(const struct pci_device_id *ent)
> +{
> + if (ent->device == PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2)
> + return 1;
> + else
> + return 0;
> +}
Make it shorter ->
return ent->device == PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2;
- Heikki
next prev parent reply other threads:[~2006-11-17 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 8:36 Peer Chen
2006-11-17 15:06 ` Heikki Orsila [this message]
2006-11-17 18:04 ` Jeff Garzik
2006-11-20 2:20 ` Peer Chen
2007-01-31 23:21 ` Kristen Carlson Accardi
2007-02-01 19:55 ` Andy Currid
2007-02-01 21:49 ` Kristen Carlson Accardi
[not found] <45A377D2.60401@garzik.org>
2007-01-10 2:50 ` Robert Hancock
[not found] <15F501D1A78BD343BE8F4D8DB854566B059FE0B3@hkemmail01.nvidia.com>
2006-10-31 8:43 ` Peer Chen
2006-10-31 10:40 ` Christoph Hellwig
2006-10-31 12:37 ` Prakash Punnoor
2006-11-07 9:55 ` Peer Chen
2007-11-07 4:09 ` Yinghai Lu
2009-01-18 9:20 ` Yinghai Lu
2006-11-01 1:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117150612.GC12227@zakalwe.fi \
--to=shd@zakalwe.fi \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=prakash@punnoor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®