* [PATCH] remove pointless test of task == NULL from i386 dump_trace()
@ 2006-11-01 23:17 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-11-01 23:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Gareth Hughes, Linus Torvalds, Jesper Juhl
In arch/i386/kernel/traps.c::dump_trace() there's a line that reads
if (task && task != current)
but at the start of the function we have
if (!task)
task = current;
So 'task' will never be NULL (since 'current' will never be NULL unless
I'm very much mistaken). Which renders the test of 'task == NULL' utter
pointless.
Removing the check should provide a microscopic speedup due to a saved
cycle or two and in addition it certainly does save a few bytes of .text
for traps.o :
before:
text data bss dec hex filename
11887 2284 52 14223 378f arch/i386/kernel/traps.o
after:
text data bss dec hex filename
11871 2284 52 14207 377f arch/i386/kernel/traps.o
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c
index 00489b7..6355ce1 100644
--- a/arch/i386/kernel/traps.c
+++ b/arch/i386/kernel/traps.c
@@ -214,7 +214,7 @@ void dump_trace(struct task_struct *task
if (!stack) {
unsigned long dummy;
stack = &dummy;
- if (task && task != current)
+ if (task != current)
stack = (unsigned long *)task->thread.esp;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-01 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-01 23:17 [PATCH] remove pointless test of task == NULL from i386 dump_trace() Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome