Re: [patch] video: support for VGA hoses on alpha TITAN, TSUNAMI systems (ES45, DS25)

[Steve Langasek <vorlon@debian.org>]

Hi Andrew,

Thanks for the feedback.  I'll incorporate your comments and Ivan's into an
updated patch and re-test.  What's the procedure afterwards -- should I
re-submit as a follow-up to this thread or start a new thread?

On Thu, Nov 02, 2006 at 01:14:43PM -0800, Andrew Morton wrote:

> > From: Jay Estabrook <jay.estabrook@hp.com>

> > Add working support for VGA hoses on Alpha, which is required in order to
> > use a VGA console on TITAN- and TSUNAMI-class Alpha systems.  This also
> > generalizes support for non-standard VGA offsets on Alpha to cover the
> > Marvel class of alphas without special-casing.  Includes recognizing an
> > additional model of TITAN-class Alpha.

> > Tested successfully on an ES45 and a DS25 with a vanilla 2.6.18 kernel,
> > also tested on an LX164 with the Debian 2.6.18 kernel with no regressions. 
> > Included in Alpha Core distribution for some time.

> It would be appropriate for both yourself and Jay to provide signoffs for
> this work, as per section 11 of Documentation/SubmittingPatches, please.

Ok, will ask Jay for this.

> What is a "hose"?

Ivan's comment, that this is effectively a PCI domain, is consistent with my
(limited) understanding.

> > +/* wait until after includes to test for this, to allow arch-specific mod. */
> > +#ifndef vga_request_resource
> > +# define vga_request_resource request_resource
> > +#endif
> > +

> erk.

Yeah. :/  Suggestions welcome.

> So we actually need to include asm/pci.h in these files?

Uhm, appears not.  Thanks for noticing.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/