mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Langasek <vorlon@debian.org>
To: Jason Harrison <jharrison@linuxbs.org>
Cc: Eki <eki@sci.fi>, Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	linux-kernel@vger.kernel.org, thias.lelourd@gmail.com
Subject: Re: [patch] video: support for VGA hoses on alpha TITAN, TSUNAMI systems (ES45, DS25)
Date: Wed, 8 Nov 2006 21:55:10 -0800	[thread overview]
Message-ID: <20061109055510.GH5314@mauritius.dodds.net> (raw)
In-Reply-To: <200611082104.37349.jharrison@linuxbs.org>

Hi Jason,

On Wed, Nov 08, 2006 at 09:04:37PM -0500, Jason Harrison wrote:

> Just wanted to let you know I tested this patch 
> http://people.debian.org/~vorlon/alpha-titan-video.patch on 2.6.18.2 sources 
> and got the following errors during the compile.  The same 2.6.18.2 sources 
> compile ok so I think this has something to do with the alpha-titan-video 
> patch.  I hope this information is useful.  I do not know too much about 
> debugging yet or I would have tried to provide more.

> In file included from include/asm/io.h:250,
>                  from include/linux/dmapool.h:14,
>                  from include/linux/pci.h:564,
>                  from arch/alpha/kernel/alpha_ksyms.c:16:
> include/asm/core_titan.h: In function 'titan_ioportmap':
> include/asm/core_titan.h:386: error: dereferencing pointer to incomplete type
> make[1]: *** [arch/alpha/kernel/alpha_ksyms.o] Error 1
> make: *** [arch/alpha/kernel] Error 2

Ok; evidently, the reference to asm/pci.h really *was* required, because
otherwise the definition of FIXUP_IOADDR_VGA() is used well before struct
pci_controller is defined when building with CONFIG_ALPHA_TITAN.  I've
re-added this to the test patch, please feel free to re-download and test.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

  reply	other threads:[~2006-11-09  5:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02  8:37 Steve Langasek
2006-11-02 21:14 ` Andrew Morton
2006-11-02 22:28   ` Ivan Kokshaysky
2006-11-04  6:35   ` Steve Langasek
2006-11-09  2:04     ` Jason Harrison
2006-11-09  5:55       ` Steve Langasek [this message]
2006-11-11 22:24         ` Jason Harrison
2006-11-11 22:40         ` Jason Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061109055510.GH5314@mauritius.dodds.net \
    --to=vorlon@debian.org \
    --cc=eki@sci.fi \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jharrison@linuxbs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=thias.lelourd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®