* Re: + net-uninline-xfrm_selector_match.patch added to -mm tree
[not found] <200611031934.kA3JYCjF030732@shell0.pdx.osdl.net>
@ 2006-11-06 22:38 ` David Miller
2006-11-06 22:49 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2006-11-06 22:38 UTC (permalink / raw)
To: linux-kernel, akpm; +Cc: acme
From: akpm@osdl.org
Date: Fri, 03 Nov 2006 11:34:12 -0800
> Subject: net: uninline xfrm_selector_match()
> From: Andrew Morton <akpm@osdl.org>
>
> Six callsites, huge.
>
> Cc: Arnaldo Carvalho de Melo <acme@mandriva.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
You can't implement it like this :-)
xfrm_user.c is a bad place to put the uninlined version because
this can be built modular, whereas the callsites in places such
as xfrm_policy.c will be built statically into the kernel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + net-uninline-xfrm_selector_match.patch added to -mm tree
2006-11-06 22:38 ` + net-uninline-xfrm_selector_match.patch added to -mm tree David Miller
@ 2006-11-06 22:49 ` Andrew Morton
2006-11-06 22:51 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2006-11-06 22:49 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, acme
On Mon, 06 Nov 2006 14:38:31 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: akpm@osdl.org
> Date: Fri, 03 Nov 2006 11:34:12 -0800
>
> > Subject: net: uninline xfrm_selector_match()
> > From: Andrew Morton <akpm@osdl.org>
> >
> > Six callsites, huge.
> >
> > Cc: Arnaldo Carvalho de Melo <acme@mandriva.com>
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
>
> You can't implement it like this :-)
>
> xfrm_user.c is a bad place to put the uninlined version because
> this can be built modular, whereas the callsites in places such
> as xfrm_policy.c will be built statically into the kernel.
I would have found that out when I got around to compiling it ;)
Where should the out-of-line function be placed, or should I just drop it?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + net-uninline-xfrm_selector_match.patch added to -mm tree
2006-11-06 22:49 ` Andrew Morton
@ 2006-11-06 22:51 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2006-11-06 22:51 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, acme
From: Andrew Morton <akpm@osdl.org>
Date: Mon, 6 Nov 2006 14:49:32 -0800
> I would have found that out when I got around to compiling it ;)
>
> Where should the out-of-line function be placed, or should I just drop it?
Either xfrm_policy.c or xfrm_state.c would work fine.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-06 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200611031934.kA3JYCjF030732@shell0.pdx.osdl.net>
2006-11-06 22:38 ` + net-uninline-xfrm_selector_match.patch added to -mm tree David Miller
2006-11-06 22:49 ` Andrew Morton
2006-11-06 22:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®