infiniband/hw/amso1100/c2_provider.c: possible NULL dereference

infiniband/hw/amso1100/c2_provider.c: possible NULL dereference

[Adrian Bunk]

The Coverity checker noted the following in 
drivers/infiniband/hw/amso1100/c2_provider.c:

<--  snip  -->

...
int c2_register_device(struct c2_dev *dev)
{
        int ret;
        int i;

        /* Register pseudo network device */
        dev->pseudo_netdev = c2_pseudo_netdev_init(dev);
        if (dev->pseudo_netdev) {
                ret = register_netdev(dev->pseudo_netdev);
                if (ret) {
                        printk(KERN_ERR PFX
                                "Unable to register netdev, ret = %d\n", ret);
                        free_netdev(dev->pseudo_netdev);
                        return ret;
                }
        }

        pr_debug("%s:%u\n", __FUNCTION__, __LINE__);
        strlcpy(dev->ibdev.name, "amso%d", IB_DEVICE_NAME_MAX);
        dev->ibdev.owner = THIS_MODULE;
        dev->ibdev.uverbs_cmd_mask =
            (1ull << IB_USER_VERBS_CMD_GET_CONTEXT) |
            (1ull << IB_USER_VERBS_CMD_QUERY_DEVICE) |
            (1ull << IB_USER_VERBS_CMD_QUERY_PORT) |
            (1ull << IB_USER_VERBS_CMD_ALLOC_PD) |
            (1ull << IB_USER_VERBS_CMD_DEALLOC_PD) |
            (1ull << IB_USER_VERBS_CMD_REG_MR) |
            (1ull << IB_USER_VERBS_CMD_DEREG_MR) |
            (1ull << IB_USER_VERBS_CMD_CREATE_COMP_CHANNEL) |
            (1ull << IB_USER_VERBS_CMD_CREATE_CQ) |
            (1ull << IB_USER_VERBS_CMD_DESTROY_CQ) |
            (1ull << IB_USER_VERBS_CMD_REQ_NOTIFY_CQ) |
            (1ull << IB_USER_VERBS_CMD_CREATE_QP) |
            (1ull << IB_USER_VERBS_CMD_MODIFY_QP) |
            (1ull << IB_USER_VERBS_CMD_POLL_CQ) |
            (1ull << IB_USER_VERBS_CMD_DESTROY_QP) |
            (1ull << IB_USER_VERBS_CMD_POST_SEND) |
            (1ull << IB_USER_VERBS_CMD_POST_RECV);

        dev->ibdev.node_type = RDMA_NODE_RNIC;
        memset(&dev->ibdev.node_guid, 0, sizeof(dev->ibdev.node_guid));
        memcpy(&dev->ibdev.node_guid, dev->pseudo_netdev->dev_addr, 6);
...                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

<--  snip  -->

Above there's an "if (dev->pseudo_netdev)" check, but here it's 
dereferenced without a check.

It seems instead of the "if (dev->pseudo_netdev)", there should be some 
kind of

  if (!dev->pseudo_netdev)
  	return -ESOME_ERROR;


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: infiniband/hw/amso1100/c2_provider.c: possible NULL dereference

[Steve WIse]

yep.  We'll fix this up asap...


Thanks,


Steve.


On Wed, 2006-11-08 at 17:28 +0100, Adrian Bunk wrote:
> The Coverity checker noted the following in 
> drivers/infiniband/hw/amso1100/c2_provider.c:
> 
> <--  snip  -->
> 
> ...
> int c2_register_device(struct c2_dev *dev)
> {
>         int ret;
>         int i;
> 
>         /* Register pseudo network device */
>         dev->pseudo_netdev = c2_pseudo_netdev_init(dev);
>         if (dev->pseudo_netdev) {
>                 ret = register_netdev(dev->pseudo_netdev);
>                 if (ret) {
>                         printk(KERN_ERR PFX
>                                 "Unable to register netdev, ret = %d\n", ret);
>                         free_netdev(dev->pseudo_netdev);
>                         return ret;
>                 }
>         }
> 
>         pr_debug("%s:%u\n", __FUNCTION__, __LINE__);
>         strlcpy(dev->ibdev.name, "amso%d", IB_DEVICE_NAME_MAX);
>         dev->ibdev.owner = THIS_MODULE;
>         dev->ibdev.uverbs_cmd_mask =
>             (1ull << IB_USER_VERBS_CMD_GET_CONTEXT) |
>             (1ull << IB_USER_VERBS_CMD_QUERY_DEVICE) |
>             (1ull << IB_USER_VERBS_CMD_QUERY_PORT) |
>             (1ull << IB_USER_VERBS_CMD_ALLOC_PD) |
>             (1ull << IB_USER_VERBS_CMD_DEALLOC_PD) |
>             (1ull << IB_USER_VERBS_CMD_REG_MR) |
>             (1ull << IB_USER_VERBS_CMD_DEREG_MR) |
>             (1ull << IB_USER_VERBS_CMD_CREATE_COMP_CHANNEL) |
>             (1ull << IB_USER_VERBS_CMD_CREATE_CQ) |
>             (1ull << IB_USER_VERBS_CMD_DESTROY_CQ) |
>             (1ull << IB_USER_VERBS_CMD_REQ_NOTIFY_CQ) |
>             (1ull << IB_USER_VERBS_CMD_CREATE_QP) |
>             (1ull << IB_USER_VERBS_CMD_MODIFY_QP) |
>             (1ull << IB_USER_VERBS_CMD_POLL_CQ) |
>             (1ull << IB_USER_VERBS_CMD_DESTROY_QP) |
>             (1ull << IB_USER_VERBS_CMD_POST_SEND) |
>             (1ull << IB_USER_VERBS_CMD_POST_RECV);
> 
>         dev->ibdev.node_type = RDMA_NODE_RNIC;
>         memset(&dev->ibdev.node_guid, 0, sizeof(dev->ibdev.node_guid));
>         memcpy(&dev->ibdev.node_guid, dev->pseudo_netdev->dev_addr, 6);
> ...                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> <--  snip  -->
> 
> Above there's an "if (dev->pseudo_netdev)" check, but here it's 
> dereferenced without a check.
> 
> It seems instead of the "if (dev->pseudo_netdev)", there should be some 
> kind of
> 
>   if (!dev->pseudo_netdev)
>   	return -ESOME_ERROR;
> 
> 
> cu
> Adrian
>