mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fix via586 irq routing for pirq 5
@ 2006-11-11 23:52 Daniel Ritz
  2006-11-12  0:47 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ritz @ 2006-11-11 23:52 UTC (permalink / raw)
  To: Greg KH, Andrew Morton
  Cc: linux-kernel, linux-pci, Daniel Paschka, Adrian Bunk

( for 2.6.19, and i think it would be good for -stable too... )

[PATCH] fix via586 irq routing for pirq 5

fix interrput routing for via 586 bridges. pirq can be 5 which needs to be
mapped to INTD. but currently the access functions can handle only pirq 1-4.
this is similar to the other via chipsets where pirq 4 and 5 are both mapped
to INTD. fixes bugzilla #7490

Cc: Daniel Paschka <monkey20181@gmx.net>
Cc: Adrian Bunk <bunk@susta.de>
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>


diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c
index dbc4aae..567126b 100644
--- a/arch/i386/pci/irq.c
+++ b/arch/i386/pci/irq.c
@@ -255,13 +255,13 @@ static int pirq_via_set(struct pci_dev *
  */
 static int pirq_via586_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
 {
-	static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
+	static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
 	return read_config_nybble(router, 0x55, pirqmap[pirq-1]);
 }
 
 static int pirq_via586_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
 {
-	static const unsigned int pirqmap[4] = { 3, 2, 5, 1 };
+	static const unsigned int pirqmap[5] = { 3, 2, 5, 1, 1 };
 	write_config_nybble(router, 0x55, pirqmap[pirq-1], irq);
 	return 1;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix via586 irq routing for pirq 5
  2006-11-11 23:52 [PATCH] fix via586 irq routing for pirq 5 Daniel Ritz
@ 2006-11-12  0:47 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-11-12  0:47 UTC (permalink / raw)
  To: Daniel Ritz; +Cc: Greg KH, linux-kernel, linux-pci, Daniel Paschka, Adrian Bunk

On Sun, 12 Nov 2006 00:52:44 +0100
Daniel Ritz <daniel.ritz-ml@swissonline.ch> wrote:

> ( for 2.6.19, and i think it would be good for -stable too... )

Yup.

> [PATCH] fix via586 irq routing for pirq 5

Thanks very much for working this one out.  Most impressive.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-11-12  0:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-11 23:52 [PATCH] fix via586 irq routing for pirq 5 Daniel Ritz
2006-11-12  0:47 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®